From: Alvin Sun <alvin.sun@linux.dev>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: rust-for-linux@vger.kernel.org, Alice Ryhl <aliceryhl@google.com>,
Gary Guo <gary@garyguo.net>
Subject: Re: merge problems with char-misc-next and Linus's branch right now
Date: Tue, 25 Aug 2026 18:00:37 +0800 [thread overview]
Message-ID: <1d80b800-8216-4731-830b-bbf055ab6e6f@linux.dev> (raw)
In-Reply-To: <2026082516-slapstick-nearly-8986@gregkh>
On 8/25/26 17:05, Greg KH wrote:
> Hi,
>
> I'm trying to push out a pull request for char-misc-next right now, and
> am having merge issues that I need/want to fix up (or at least provide a
> hint as to fix up.)
>
> I'm currently stuck at the following build error:
>
> RUSTC drivers/android/binder/rust_binder_main.o
> error[E0425]: cannot find value `THIS_MODULE` in the crate root
> --> drivers/android/binder/netlink.rs:16:13
> |
> 16 | &crate::THIS_MODULE,
> | ^^^^^^^^^^^
> |
> ::: rust/kernel/module.rs:52:1
> |
> 52 | pub const fn this_module<M: ModuleMetadata>() -> &'static ThisModule {
> | -------------------------------------------------------------------- similarly named function `this_module` defined here
> |
> help: a function with a similar name exists
> |
> 16 - &crate::THIS_MODULE,
> 16 + &crate::this_module,
> |
>
> error: aborting due to 1 previous error
>
>
> I wasn't paying attention to the recent THIS_MODULE changes, and can't
> seem to figure out how to fix up the netlink.rs file to build with the
> recent changes.
>
> Any hints?
Hi Greg,
Gary has already posted a fix:
https://lore.kernel.org/rust-for-linux/20260813163951.1102583-1-gary@kernel.org/
Best regards,
Alvin
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2026-08-25 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 9:05 merge problems with char-misc-next and Linus's branch right now Greg KH
2026-08-25 10:00 ` Alvin Sun [this message]
2026-08-25 10:49 ` Miguel Ojeda
2026-08-25 11:08 ` Greg KH
2026-08-25 11:45 ` Greg KH
2026-08-25 10:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d80b800-8216-4731-830b-bbf055ab6e6f@linux.dev \
--to=alvin.sun@linux.dev \
--cc=aliceryhl@google.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox