public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <ttabi@nvidia.com>
To: "gary@garyguo.net" <gary@garyguo.net>,
	Alexandre Courbot <acourbot@nvidia.com>,
	"dakr@kernel.org" <dakr@kernel.org>,
	Eliot Courtney <ecourtney@nvidia.com>,
	Joel Fernandes <joelagnelf@nvidia.com>,
	John Hubbard <jhubbard@nvidia.com>,
	"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v3 5/6] gpu: nova-core: skip the IFR header if present
Date: Thu, 16 Apr 2026 16:03:26 +0000	[thread overview]
Message-ID: <1dfabd4281e04d9d3027787eef388bb811ee5d56.camel@nvidia.com> (raw)
In-Reply-To: <5dc896f1-fa0f-4ed3-9744-420aa35368b1@nvidia.com>

On Wed, 2026-04-15 at 18:34 -0700, John Hubbard wrote:
> > > > > +    if signature == NV_PBUS_IFR_FMT_FIXED0_SIGNATURE_VALUE {
> > > > > +        let fixed1 = bar0.read(ga100::NV_PBUS_IFR_FMT_FIXED1);
> > > > > +
> > > > > +        match fixed1.version() {
> > > > > +            // Note: We do not actually expect to see v1 or v2 on these GPUs
> > > > 
> > > > Then why even match for it? No need to "support" HW or FW that doesn't,
> > > > and won't ever exist, right?
> > > 
> > > As I tried to explain last time, I'm not 100% sure that we'll never see it.  It's just a
> > > footnote, based on my examination of various documents on the IFR.  
> > 
> > I missed that, sorry. Let's either delete the comment, or else water
> > it down to...well, I don't know what. Probably best to simply delete 
> > it, otherwise someone will want to delete the code.
> > 
> > Either you think that there is *some* chance that this code is not
> > perma-dead, or you don't. And it sounds like the latter.
> > 
> 
> ...ummm, let me reverse the polarity of that last sentence. :)

Well, you're the second person who apparently has a different definition of "expect" than I do,
so I will remove the comment.

Or Alex can remove it if we wants, if he pulls in v3 otherwise.

  reply	other threads:[~2026-04-16 16:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16  0:26 [PATCH v3 0/6] gpu: nova-core: add GA100 support Timur Tabi
2026-04-16  0:26 ` [PATCH v3 1/6] gpu: nova-core: use correct fwsignature for GA100 Timur Tabi
2026-04-16  0:26 ` [PATCH v3 2/6] gpu: nova-core: do not consider 0xBB77 as a valid PCI ROM header signature Timur Tabi
2026-04-16  0:26 ` [PATCH v3 3/6] gpu: nova-core: only boot FRTS if its region is allocated Timur Tabi
2026-04-16  0:26 ` [PATCH v3 4/6] gpu: nova-core: add FbHal::frts_size() for GA100 support Timur Tabi
2026-04-16  0:26 ` [PATCH v3 5/6] gpu: nova-core: skip the IFR header if present Timur Tabi
2026-04-16  1:21   ` John Hubbard
2026-04-16  1:24     ` Timur Tabi
2026-04-16  1:32       ` John Hubbard
2026-04-16  1:34         ` John Hubbard
2026-04-16 16:03           ` Timur Tabi [this message]
2026-04-16  0:26 ` [PATCH v3 6/6] gpu: nova-core: enable GA100 Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dfabd4281e04d9d3027787eef388bb811ee5d56.camel@nvidia.com \
    --to=ttabi@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox