rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Elijah Wright" <git@elijahs.space>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"Uladzislau Rezki" <urezki@gmail.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH] rust: slab: add basic slab module
Date: Fri, 26 Sep 2025 18:32:01 +0200	[thread overview]
Message-ID: <1f5ae3bd-db21-4042-b177-55464644ce2e@suse.cz> (raw)
In-Reply-To: <DD2URCNO2P88.168J48GHSJRRL@kernel.org>

On 9/26/25 17:55, Danilo Krummrich wrote:
> On Fri Sep 26, 2025 at 5:33 PM CEST, Danilo Krummrich wrote:
>> The only thing we need on the Rust side is that existing allocations remain
>> valid even if the cache is destroyed. Or the other way around the cache is
>> silently kept alive internally.
> 
> Or to express it in C code:
> 
> 	struct kmem_cache *cache = kmem_cache_create();
> 	struct Foo *foo = kmem_cache_alloc();
> 
> 	// After this call cache will never be accessed; leaves a zombie cache,
> 	// since foo is still alive.
> 	kmem_cache_destroy(cache);

This will cause a WARN.

> 	// This must still be valid.
> 	foo->bar = 42;

Yes this will be safe.

> 	// Frees foo and causes the "zombie" cache to actually be destroyed.
> 	kmem_cache_free(foo);

The free will be fine. But not cause the cache destruction, as that would
require checks on each free. But should be fine wrt safety if we only leak
some memory due to a wrong usage, no?

  reply	other threads:[~2025-09-26 16:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 19:36 [PATCH] rust: slab: add basic slab module Elijah Wright
2025-09-25  2:17 ` John Hubbard
2025-09-25  8:01 ` Benno Lossin
2025-09-25  9:54 ` Danilo Krummrich
2025-09-25 17:20   ` Elijah
2025-09-25 17:43     ` Danilo Krummrich
2025-09-25 18:02       ` Liam R. Howlett
2025-09-25 18:08         ` Danilo Krummrich
2025-09-25 18:11         ` Boqun Feng
2025-09-25 18:05       ` Elijah
2025-09-25 18:15         ` Danilo Krummrich
2025-09-25 18:17           ` Danilo Krummrich
     [not found]           ` <74b3ef24-a307-4d3c-891a-8c5283448b20@elijahs.space>
2025-09-25 18:52             ` Elijah
2025-09-25 17:54   ` Alice Ryhl
2025-09-26 15:00   ` Vlastimil Babka
2025-09-26 15:33     ` Danilo Krummrich
2025-09-26 15:55       ` Danilo Krummrich
2025-09-26 16:32         ` Vlastimil Babka [this message]
2025-09-26 16:58           ` Danilo Krummrich
2025-09-26 17:11             ` Vlastimil Babka
2025-09-26 19:01               ` Danilo Krummrich
2025-09-28 14:47   ` Danilo Krummrich
2025-09-29  7:14     ` Vlastimil Babka
2025-09-29 14:11     ` Elijah
2025-09-29 20:32       ` Danilo Krummrich
2025-10-01  4:44 ` [PATCH v2] " Elijah Wright
2025-11-06  7:53   ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f5ae3bd-db21-4042-b177-55464644ce2e@suse.cz \
    --to=vbabka@suse.cz \
    --cc=Liam.Howlett@oracle.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=git@elijahs.space \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).