From: Gary Guo <gary@garyguo.net>
To: Laine Taffin Altman <alexanderaltman@me.com>
Cc: "Wedson Almeida Filho" <wedsonaf@gmail.com>,
rust-for-linux@vger.kernel.org, "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] rust: sync: introduce `UniqueArc`
Date: Sat, 31 Dec 2022 19:46:58 +0000 [thread overview]
Message-ID: <20221231194658.4f45055d.gary@garyguo.net> (raw)
In-Reply-To: <792D12DA-73F0-4218-B0E1-7A0D8C235C21@me.com>
On Tue, 27 Dec 2022 23:19:52 -0800
Laine Taffin Altman <alexanderaltman@me.com> wrote:
> > +impl<T: ?Sized> From<UniqueArc<T>> for Pin<UniqueArc<T>> {
> > + fn from(obj: UniqueArc<T>) -> Self {
> > + // SAFETY: It is not possible to move/replace `T` inside a `Pin<UniqueArc<T>>` (unless `T`
>
> Minor nit: `Pin<UniqueArc<T>>` in this comment should just be `UniqueArc<T>`.
No, the current comment is correct. It's possible to move `T` inside
`UniqueArc<T>` (because it implements `DerefMut`).
Best,
Gary Guo
next prev parent reply other threads:[~2022-12-31 19:47 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 6:03 [PATCH 1/7] rust: sync: add `Arc` for ref-counted allocations Wedson Almeida Filho
2022-12-28 6:03 ` [PATCH 2/7] rust: sync: allow type of `self` to be `Arc<T>` or variants Wedson Almeida Filho
2022-12-28 10:03 ` Alice Ryhl
2022-12-31 19:37 ` Gary Guo
2023-01-04 16:12 ` Vincenzo
2022-12-28 6:03 ` [PATCH 3/7] rust: sync: allow coercion from `Arc<T>` to `Arc<U>` Wedson Almeida Filho
2022-12-28 10:03 ` Alice Ryhl
2022-12-31 19:37 ` Gary Guo
2023-01-04 16:13 ` Vincenzo
2022-12-28 6:03 ` [PATCH 4/7] rust: sync: introduce `ArcBorrow` Wedson Almeida Filho
2022-12-28 7:15 ` Laine Taffin Altman
2022-12-28 10:03 ` Alice Ryhl
2022-12-31 19:43 ` Gary Guo
2023-01-04 15:29 ` Wedson Almeida Filho
2023-01-04 16:06 ` Emilio Cobos Álvarez
2023-01-04 17:52 ` Wedson Almeida Filho
2023-01-16 22:07 ` Gary Guo
2023-01-21 0:44 ` Boqun Feng
2023-01-16 22:42 ` Vincenzo Palazzo
2022-12-28 6:03 ` [PATCH 5/7] rust: sync: allow type of `self` to be `ArcBorrow<T>` Wedson Almeida Filho
2022-12-28 10:04 ` Alice Ryhl
2022-12-31 19:44 ` Gary Guo
2023-01-04 16:18 ` Vincenzo
2022-12-28 6:03 ` [PATCH 6/7] rust: sync: introduce `UniqueArc` Wedson Almeida Filho
2022-12-28 7:19 ` Laine Taffin Altman
2022-12-31 19:46 ` Gary Guo [this message]
2022-12-28 10:04 ` Alice Ryhl
2022-12-31 19:47 ` Gary Guo
2023-01-04 16:21 ` Vincenzo
2022-12-28 6:03 ` [PATCH 7/7] rust: sync: add support for dispatching on Arc and ArcBorrow Wedson Almeida Filho
2022-12-28 7:24 ` Laine Taffin Altman
2022-12-31 19:51 ` Gary Guo
2022-12-28 10:04 ` Alice Ryhl
2022-12-31 19:52 ` Gary Guo
2023-01-04 16:26 ` Vincenzo
2022-12-28 7:09 ` [PATCH 1/7] rust: sync: add `Arc` for ref-counted allocations Laine Taffin Altman
2022-12-28 7:27 ` Wedson Almeida Filho
2022-12-28 7:32 ` Laine Taffin Altman
2022-12-28 10:03 ` Alice Ryhl
2022-12-28 10:14 ` Wedson Almeida Filho
2022-12-28 10:38 ` Alice Ryhl
2022-12-31 19:55 ` Gary Guo
2023-01-04 16:08 ` Vincenzo
2023-01-10 20:22 ` Boqun Feng
2023-01-10 21:20 ` Peter Zijlstra
2023-01-10 21:36 ` Boqun Feng
2023-01-10 21:54 ` Peter Zijlstra
2023-01-16 21:06 ` Boqun Feng
2023-01-16 23:34 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221231194658.4f45055d.gary@garyguo.net \
--to=gary@garyguo.net \
--cc=alex.gaynor@gmail.com \
--cc=alexanderaltman@me.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).