From: Wedson Almeida Filho <wedsonaf@gmail.com>
To: rust-for-linux@vger.kernel.org
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
linux-kernel@vger.kernel.org,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>,
"Alice Ferrazzi" <alice.ferrazzi@miraclelinux.com>
Subject: [PATCH v2 5/5] rust: types: implement `ForeignOwnable` for `Arc<T>`
Date: Mon, 30 Jan 2023 03:44:04 -0300 [thread overview]
Message-ID: <20230130064404.744600-5-wedsonaf@gmail.com> (raw)
In-Reply-To: <20230130064404.744600-1-wedsonaf@gmail.com>
This allows us to hand ownership of Rust ref-counted objects to
the C side of the kernel.
Signed-off-by: Wedson Almeida Filho <wedsonaf@gmail.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Reviewed-by: Alice Ferrazzi <alice.ferrazzi@miraclelinux.com>
---
v1 -> v2: Unmodified
rust/kernel/sync/arc.rs | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
index ff73f9240ca1..519a6ec43644 100644
--- a/rust/kernel/sync/arc.rs
+++ b/rust/kernel/sync/arc.rs
@@ -15,7 +15,11 @@
//!
//! [`Arc`]: https://doc.rust-lang.org/std/sync/struct.Arc.html
-use crate::{bindings, error::Result, types::Opaque};
+use crate::{
+ bindings,
+ error::Result,
+ types::{ForeignOwnable, Opaque},
+};
use alloc::boxed::Box;
use core::{
marker::{PhantomData, Unsize},
@@ -189,6 +193,32 @@ impl<T: ?Sized> Arc<T> {
}
}
+impl<T: 'static> ForeignOwnable for Arc<T> {
+ type Borrowed<'a> = ArcBorrow<'a, T>;
+
+ fn into_foreign(self) -> *const core::ffi::c_void {
+ ManuallyDrop::new(self).ptr.as_ptr() as _
+ }
+
+ unsafe fn borrow<'a>(ptr: *const core::ffi::c_void) -> ArcBorrow<'a, T> {
+ // SAFETY: By the safety requirement of this function, we know that `ptr` came from
+ // a previous call to `Arc::into_foreign`.
+ let inner = NonNull::new(ptr as *mut ArcInner<T>).unwrap();
+
+ // SAFETY: The safety requirements of `from_foreign` ensure that the object remains alive
+ // for the lifetime of the returned value. Additionally, the safety requirements of
+ // `ForeignOwnable::borrow_mut` ensure that no new mutable references are created.
+ unsafe { ArcBorrow::new(inner) }
+ }
+
+ unsafe fn from_foreign(ptr: *const core::ffi::c_void) -> Self {
+ // SAFETY: By the safety requirement of this function, we know that `ptr` came from
+ // a previous call to `Arc::into_foreign`, which owned guarantees that `ptr` is valid and
+ // owns a reference.
+ unsafe { Self::from_inner(NonNull::new(ptr as _).unwrap()) }
+ }
+}
+
impl<T: ?Sized> Deref for Arc<T> {
type Target = T;
--
2.34.1
next prev parent reply other threads:[~2023-01-30 6:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 6:44 [PATCH v2 1/5] rust: types: introduce `ScopeGuard` Wedson Almeida Filho
2023-01-30 6:44 ` [PATCH v2 2/5] rust: types: introduce `ForeignOwnable` Wedson Almeida Filho
2023-01-30 18:49 ` Gary Guo
2023-02-01 9:35 ` Andreas Hindborg
2023-01-30 6:44 ` [PATCH v2 3/5] rust: types: implement `ForeignOwnable` for `Box<T>` Wedson Almeida Filho
2023-02-01 9:56 ` Andreas Hindborg
2023-01-30 6:44 ` [PATCH v2 4/5] rust: types: implement `ForeignOwnable` for the unit type Wedson Almeida Filho
2023-01-30 18:41 ` Gary Guo
2023-02-01 9:58 ` Andreas Hindborg
2023-01-30 6:44 ` Wedson Almeida Filho [this message]
2023-02-01 10:17 ` [PATCH v2 5/5] rust: types: implement `ForeignOwnable` for `Arc<T>` Andreas Hindborg
2023-02-06 23:47 ` Miguel Ojeda
2023-02-07 9:32 ` Andreas Hindborg
2023-02-07 10:26 ` Miguel Ojeda
2023-01-30 18:50 ` [PATCH v2 1/5] rust: types: introduce `ScopeGuard` Gary Guo
2023-01-30 20:07 ` Andreas Hindborg
2023-02-01 1:00 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130064404.744600-5-wedsonaf@gmail.com \
--to=wedsonaf@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=alice.ferrazzi@miraclelinux.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=vincenzopalazzodev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).