From: Boqun Feng <boqun.feng@gmail.com>
To: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Will Deacon" <will@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
Subject: [RFC 0/5] rust: sync: Arc: Implement Debug and Display
Date: Wed, 1 Feb 2023 15:22:39 -0800 [thread overview]
Message-ID: <20230201232244.212908-1-boqun.feng@gmail.com> (raw)
I found that our Arc doesn't implement `Debug` or `Display` when I tried
to play with them, therefore add these implementation.
With these changes, I could get the following print with the sample code
in patch #5:
[..] rust_print: 1
[..] rust_print: UniqueArc { inner: Arc { refcount: 1, data: "hello, world" } }
[..] rust_print: [samples/rust/rust_print.rs:34] c = Arc {
[..] refcount: 2,
[..] data: "hello, world",
[..] }
[..] rust_print: Arc {
[..] refcount: 0x1,
[..] data: "hello, world",
[..] }
Note that I make the `Debug` implementation of `Arc` also print the
current reference count, which I think may be useful: myself sometimes
wonder "how many references exist at this point" during my own
development. But I'm open to suggestions and changes.
Wedson, I know that you are considering to get rid of `ArcBorrow`, so
the patch #3 may have some conflicts with what you may be working on.
I'm happy to wait and rebase since this series is not something urgent
;-)
Suggestions and comments are welcome!
Regards,
Boqun
next reply other threads:[~2023-02-01 23:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 23:22 Boqun Feng [this message]
2023-02-01 23:22 ` [RFC 1/5] rust: sync: impl Display for {Unique,}Arc Boqun Feng
2023-02-02 14:15 ` Gary Guo
2023-02-02 16:50 ` Björn Roy Baron
2023-02-04 10:20 ` Finn Behrens
2023-02-04 18:47 ` Vincenzo Palazzo
2023-02-01 23:22 ` [RFC 2/5] rust: sync: Arc: Introduces ArcInner::count() Boqun Feng
2023-02-02 9:14 ` Peter Zijlstra
2023-02-02 13:46 ` Boqun Feng
2023-02-02 14:21 ` Gary Guo
2023-02-02 15:41 ` Greg KH
2023-02-02 16:10 ` Boqun Feng
2023-02-02 16:17 ` Greg KH
2023-02-02 16:51 ` Boqun Feng
2023-02-02 21:47 ` Miguel Ojeda
2023-02-03 5:22 ` Greg KH
2023-02-03 7:25 ` Boqun Feng
2023-02-03 7:38 ` Greg KH
2023-02-03 7:43 ` Boqun Feng
2023-02-03 8:01 ` Boqun Feng
2023-02-03 19:17 ` Josh Stone
2023-02-03 19:22 ` Wedson Almeida Filho
2023-02-02 14:22 ` Gary Guo
2023-02-04 18:48 ` Vincenzo Palazzo
2023-02-01 23:22 ` [RFC 3/5] rust: sync: Arc: Introduces Arc::get_inner() helper Boqun Feng
2023-02-02 14:24 ` Gary Guo
2023-02-02 16:53 ` Björn Roy Baron
2023-02-04 18:51 ` Vincenzo Palazzo
2023-02-01 23:22 ` [RFC 4/5] rust: sync: impl Debug for {Unique,}Arc Boqun Feng
2023-02-02 14:28 ` Gary Guo
2023-02-03 19:46 ` Boqun Feng
2023-02-04 18:56 ` Vincenzo Palazzo
2023-02-01 23:22 ` [RFC 5/5] sample: rust: print: Add sampe code for Arc printing Boqun Feng
2023-02-02 16:56 ` Björn Roy Baron
2023-02-04 10:22 ` Finn Behrens
2023-02-04 19:05 ` Vincenzo Palazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201232244.212908-1-boqun.feng@gmail.com \
--to=boqun.feng@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=vincenzopalazzodev@gmail.com \
--cc=wedsonaf@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).