From: Asahi Lina <lina@asahilina.net>
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
asahi@lists.linux.dev, Asahi Lina <lina@asahilina.net>
Subject: [PATCH 2/3] rust: macros: concat_idents: Allow :: paths in the first argument
Date: Fri, 24 Feb 2023 16:25:56 +0900 [thread overview]
Message-ID: <20230224-rust-macros-v1-2-b39fae46e102@asahilina.net> (raw)
In-Reply-To: <20230224-rust-macros-v1-0-b39fae46e102@asahilina.net>
This makes things like concat_idents!(bindings::foo, bar) work.
Otherwise, there is no way to concatenate two idents and then use the
result as part of a type path.
Signed-off-by: Asahi Lina <lina@asahilina.net>
---
rust/macros/concat_idents.rs | 24 +++++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/rust/macros/concat_idents.rs b/rust/macros/concat_idents.rs
index 6d955d65016e..d6614b900aa2 100644
--- a/rust/macros/concat_idents.rs
+++ b/rust/macros/concat_idents.rs
@@ -14,10 +14,28 @@ fn expect_ident(it: &mut token_stream::IntoIter) -> Ident {
pub(crate) fn concat_idents(ts: TokenStream) -> TokenStream {
let mut it = ts.into_iter();
- let a = expect_ident(&mut it);
- assert_eq!(expect_punct(&mut it).as_char(), ',');
+ let mut out = TokenStream::new();
+ let a = loop {
+ let ident = expect_ident(&mut it);
+ let punct = expect_punct(&mut it);
+ match punct.as_char() {
+ ',' => break ident,
+ ':' => {
+ let punct2 = expect_punct(&mut it);
+ assert_eq!(punct2.as_char(), ':');
+ out.extend([
+ TokenTree::Ident(ident),
+ TokenTree::Punct(punct),
+ TokenTree::Punct(punct2),
+ ]);
+ }
+ _ => panic!("Expected , or ::"),
+ }
+ };
+
let b = expect_ident(&mut it);
assert!(it.next().is_none(), "only two idents can be concatenated");
let res = Ident::new(&format!("{a}{b}"), b.span());
- TokenStream::from_iter([TokenTree::Ident(res)])
+ out.extend([TokenTree::Ident(res)]);
+ out
}
--
2.35.1
next prev parent reply other threads:[~2023-02-24 7:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 7:25 [PATCH 0/3] rust: Miscellaneous macro improvements Asahi Lina
2023-02-24 7:25 ` [PATCH 1/3] rust: macros: Make expect_punct() return the Punct directly Asahi Lina
2023-02-25 0:29 ` Gary Guo
2023-02-28 9:29 ` Finn Behrens
2023-03-01 17:16 ` Vincenzo Palazzo
2023-02-24 7:25 ` Asahi Lina [this message]
2023-02-25 0:31 ` [PATCH 2/3] rust: macros: concat_idents: Allow :: paths in the first argument Gary Guo
2023-03-07 20:22 ` Miguel Ojeda
2023-03-08 20:57 ` Miguel Ojeda
2023-03-01 17:18 ` Vincenzo Palazzo
2023-02-24 7:25 ` [PATCH 3/3] rust: macros: Allow specifying multiple module aliases Asahi Lina
2023-02-24 7:38 ` Greg KH
2023-02-24 12:41 ` Asahi Lina
2023-02-24 12:49 ` Greg KH
2023-03-01 17:19 ` Vincenzo Palazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224-rust-macros-v1-2-b39fae46e102@asahilina.net \
--to=lina@asahilina.net \
--cc=alex.gaynor@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).