* [PATCH v1] rust: build: Fix grep warning
@ 2023-03-02 13:21 Vincenzo Palazzo
2023-03-02 14:21 ` Martin Rodriguez Reboredo
2023-04-06 22:50 ` Miguel Ojeda
0 siblings, 2 replies; 3+ messages in thread
From: Vincenzo Palazzo @ 2023-03-02 13:21 UTC (permalink / raw)
To: rust-for-linux; +Cc: ojeda, Vincenzo Palazzo
Fix grep warning during the build, with GNU grep 3.8
with the following command
`grep -v '^\#\|^$$' rust/bindgen_parameters`
I see the following warning
```
grep: warning: stray \ before #
--opaque-type xregs_state
--opaque-type desc_struct
--opaque-type arch_lbr_state
--opaque-type local_apic
--opaque-type x86_msi_data
--opaque-type x86_msi_addr_lo
--opaque-type kunit_try_catch
--opaque-type spinlock
--no-doc-comments
```
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
---
rust/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/Makefile b/rust/Makefile
index f88d108fbef0..41ac8401a8be 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -283,7 +283,7 @@ quiet_cmd_bindgen = BINDGEN $@
$(bindgen_target_cflags) $(bindgen_target_extra)
$(obj)/bindings/bindings_generated.rs: private bindgen_target_flags = \
- $(shell grep -v '^\#\|^$$' $(srctree)/$(src)/bindgen_parameters)
+ $(shell grep -v '^#\|^$$' $(srctree)/$(src)/bindgen_parameters)
$(obj)/bindings/bindings_generated.rs: $(src)/bindings/bindings_helper.h \
$(src)/bindgen_parameters FORCE
$(call if_changed_dep,bindgen)
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] rust: build: Fix grep warning
2023-03-02 13:21 [PATCH v1] rust: build: Fix grep warning Vincenzo Palazzo
@ 2023-03-02 14:21 ` Martin Rodriguez Reboredo
2023-04-06 22:50 ` Miguel Ojeda
1 sibling, 0 replies; 3+ messages in thread
From: Martin Rodriguez Reboredo @ 2023-03-02 14:21 UTC (permalink / raw)
To: Vincenzo Palazzo, rust-for-linux; +Cc: ojeda
On 3/2/23 10:21, Vincenzo Palazzo wrote:
> Fix grep warning during the build, with GNU grep 3.8
> with the following command
>
> `grep -v '^\#\|^$$' rust/bindgen_parameters`
>
> I see the following warning
>
> ```
> grep: warning: stray \ before #
>
> --opaque-type xregs_state
> --opaque-type desc_struct
> --opaque-type arch_lbr_state
> --opaque-type local_apic
>
> --opaque-type x86_msi_data
> --opaque-type x86_msi_addr_lo
>
> --opaque-type kunit_try_catch
>
> --opaque-type spinlock
>
> --no-doc-comments
> ```
>
> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
> ---
> rust/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/Makefile b/rust/Makefile
> index f88d108fbef0..41ac8401a8be 100644
> --- a/rust/Makefile
> +++ b/rust/Makefile
> @@ -283,7 +283,7 @@ quiet_cmd_bindgen = BINDGEN $@
> $(bindgen_target_cflags) $(bindgen_target_extra)
>
> $(obj)/bindings/bindings_generated.rs: private bindgen_target_flags = \
> - $(shell grep -v '^\#\|^$$' $(srctree)/$(src)/bindgen_parameters)
> + $(shell grep -v '^#\|^$$' $(srctree)/$(src)/bindgen_parameters)
> $(obj)/bindings/bindings_generated.rs: $(src)/bindings/bindings_helper.h \
> $(src)/bindgen_parameters FORCE
> $(call if_changed_dep,bindgen)
Because this is surrounded by quotes there's no problem to no escape it.
Tested-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] rust: build: Fix grep warning
2023-03-02 13:21 [PATCH v1] rust: build: Fix grep warning Vincenzo Palazzo
2023-03-02 14:21 ` Martin Rodriguez Reboredo
@ 2023-04-06 22:50 ` Miguel Ojeda
1 sibling, 0 replies; 3+ messages in thread
From: Miguel Ojeda @ 2023-04-06 22:50 UTC (permalink / raw)
To: Vincenzo Palazzo; +Cc: rust-for-linux, ojeda
On Thu, Mar 2, 2023 at 2:21 PM Vincenzo Palazzo
<vincenzopalazzodev@gmail.com> wrote:
>
> Fix grep warning during the build, with GNU grep 3.8
> with the following command
Applied to `rust-fixes`. Thanks!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-06 22:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-02 13:21 [PATCH v1] rust: build: Fix grep warning Vincenzo Palazzo
2023-03-02 14:21 ` Martin Rodriguez Reboredo
2023-04-06 22:50 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).