From: Gary Guo <gary@garyguo.net>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: wedsonaf@gmail.com, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kernel@collabora.com
Subject: Re: [PATCH] rust: virtio: add virtio support
Date: Tue, 7 Mar 2023 16:46:03 +0000 [thread overview]
Message-ID: <20230307164603.686281dc.gary@garyguo.net> (raw)
In-Reply-To: <20230307130332.53029-1-daniel.almeida@collabora.com>
On Tue, 7 Mar 2023 10:03:32 -0300
Daniel Almeida <daniel.almeida@collabora.com> wrote:
> This patch adds virtIO support to the rust crate. This includes the
> capability to create a virtIO driver (through the module_virtio_driver
> macro and the respective Driver trait) as well as initial virtqueue
> support.
>
> A sample virtIO module is included for conveninence.
>
> Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
> ---
>
> Ok so this is my first Rust contribution here. It's part of a virtIO
> driver I was originally writing. Both the probing and the virtqueue
> support in here were confirmed as working in said prototype driver, and
> the pieces were picked separately into this patch.
>
> Feel free to point me to the best practices around Rust patch
> submission, as the C stuff like checkpatch etc probably does not apply
> yet. I did take care to run clippy though.
Hi Daniel,
This patch seems to be based on top the GitHub rust branch, not the
rust-next branch.
Best,
Gary
next prev parent reply other threads:[~2023-03-07 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 13:03 [PATCH] rust: virtio: add virtio support Daniel Almeida
2023-03-07 16:46 ` Gary Guo [this message]
2023-03-08 4:08 ` Wedson Almeida Filho
2023-03-07 17:09 ` Björn Roy Baron
2023-03-08 0:33 ` FUJITA Tomonori
2023-03-08 3:36 ` Miguel Ojeda
2023-03-07 18:08 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307164603.686281dc.gary@garyguo.net \
--to=gary@garyguo.net \
--cc=daniel.almeida@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).