From: Asahi Lina <lina@asahilina.net>
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>
Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
asahi@lists.linux.dev, Asahi Lina <lina@asahilina.net>
Subject: [PATCH 2/2] rust: ioctl: Move to the uapi crate
Date: Wed, 29 Mar 2023 20:40:19 +0900 [thread overview]
Message-ID: <20230329-rust-uapi-v1-2-ee78f2933726@asahilina.net> (raw)
In-Reply-To: <20230329-rust-uapi-v1-0-ee78f2933726@asahilina.net>
Now that we have the uapi crate, this abstraction can use that instead
of bindings.
Signed-off-by: Asahi Lina <lina@asahilina.net>
---
rust/kernel/ioctl.rs | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/rust/kernel/ioctl.rs b/rust/kernel/ioctl.rs
index b2076113b6a8..007437959395 100644
--- a/rust/kernel/ioctl.rs
+++ b/rust/kernel/ioctl.rs
@@ -10,40 +10,40 @@ use crate::build_assert;
/// Build an ioctl number, analogous to the C macro of the same name.
#[inline(always)]
const fn _IOC(dir: u32, ty: u32, nr: u32, size: usize) -> u32 {
- build_assert!(dir <= bindings::_IOC_DIRMASK);
- build_assert!(ty <= bindings::_IOC_TYPEMASK);
- build_assert!(nr <= bindings::_IOC_NRMASK);
- build_assert!(size <= (bindings::_IOC_SIZEMASK as usize));
+ build_assert!(dir <= uapi::_IOC_DIRMASK);
+ build_assert!(ty <= uapi::_IOC_TYPEMASK);
+ build_assert!(nr <= uapi::_IOC_NRMASK);
+ build_assert!(size <= (uapi::_IOC_SIZEMASK as usize));
- (dir << bindings::_IOC_DIRSHIFT)
- | (ty << bindings::_IOC_TYPESHIFT)
- | (nr << bindings::_IOC_NRSHIFT)
- | ((size as u32) << bindings::_IOC_SIZESHIFT)
+ (dir << uapi::_IOC_DIRSHIFT)
+ | (ty << uapi::_IOC_TYPESHIFT)
+ | (nr << uapi::_IOC_NRSHIFT)
+ | ((size as u32) << uapi::_IOC_SIZESHIFT)
}
/// Build an ioctl number for an argumentless ioctl.
#[inline(always)]
pub const fn _IO(ty: u32, nr: u32) -> u32 {
- _IOC(bindings::_IOC_NONE, ty, nr, 0)
+ _IOC(uapi::_IOC_NONE, ty, nr, 0)
}
/// Build an ioctl number for an read-only ioctl.
#[inline(always)]
pub const fn _IOR<T>(ty: u32, nr: u32) -> u32 {
- _IOC(bindings::_IOC_READ, ty, nr, core::mem::size_of::<T>())
+ _IOC(uapi::_IOC_READ, ty, nr, core::mem::size_of::<T>())
}
/// Build an ioctl number for an write-only ioctl.
#[inline(always)]
pub const fn _IOW<T>(ty: u32, nr: u32) -> u32 {
- _IOC(bindings::_IOC_WRITE, ty, nr, core::mem::size_of::<T>())
+ _IOC(uapi::_IOC_WRITE, ty, nr, core::mem::size_of::<T>())
}
/// Build an ioctl number for a read-write ioctl.
#[inline(always)]
pub const fn _IOWR<T>(ty: u32, nr: u32) -> u32 {
_IOC(
- bindings::_IOC_READ | bindings::_IOC_WRITE,
+ uapi::_IOC_READ | uapi::_IOC_WRITE,
ty,
nr,
core::mem::size_of::<T>(),
@@ -52,20 +52,20 @@ pub const fn _IOWR<T>(ty: u32, nr: u32) -> u32 {
/// Get the ioctl direction from an ioctl number.
pub const fn _IOC_DIR(nr: u32) -> u32 {
- (nr >> bindings::_IOC_DIRSHIFT) & bindings::_IOC_DIRMASK
+ (nr >> uapi::_IOC_DIRSHIFT) & uapi::_IOC_DIRMASK
}
/// Get the ioctl type from an ioctl number.
pub const fn _IOC_TYPE(nr: u32) -> u32 {
- (nr >> bindings::_IOC_TYPESHIFT) & bindings::_IOC_TYPEMASK
+ (nr >> uapi::_IOC_TYPESHIFT) & uapi::_IOC_TYPEMASK
}
/// Get the ioctl number from an ioctl number.
pub const fn _IOC_NR(nr: u32) -> u32 {
- (nr >> bindings::_IOC_NRSHIFT) & bindings::_IOC_NRMASK
+ (nr >> uapi::_IOC_NRSHIFT) & uapi::_IOC_NRMASK
}
/// Get the ioctl size from an ioctl number.
pub const fn _IOC_SIZE(nr: u32) -> usize {
- ((nr >> bindings::_IOC_SIZESHIFT) & bindings::_IOC_SIZEMASK) as usize
+ ((nr >> uapi::_IOC_SIZESHIFT) & uapi::_IOC_SIZEMASK) as usize
}
--
2.40.0
next prev parent reply other threads:[~2023-03-29 11:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 11:40 [PATCH 0/2] rust: Add uapi crate Asahi Lina
2023-03-29 11:40 ` [PATCH 1/2] rust: uapi: Add UAPI crate Asahi Lina
2023-03-29 15:21 ` Martin Rodriguez Reboredo
2023-03-29 20:25 ` Gary Guo
2023-03-29 11:40 ` Asahi Lina [this message]
2023-03-29 15:28 ` [PATCH 2/2] rust: ioctl: Move to the uapi crate Martin Rodriguez Reboredo
2023-03-29 20:29 ` Gary Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329-rust-uapi-v1-2-ee78f2933726@asahilina.net \
--to=lina@asahilina.net \
--cc=alex.gaynor@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).