From: y86-dev@protonmail.com
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Alice Ryhl" <alice@ryhl.io>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@lists.linux.dev
Subject: [PATCH v3 02/13] rust: sync: add `assume_init` to `UniqueArc`
Date: Wed, 29 Mar 2023 22:32:58 +0000 [thread overview]
Message-ID: <20230329223239.138757-3-y86-dev@protonmail.com> (raw)
In-Reply-To: <20230329223239.138757-1-y86-dev@protonmail.com>
From: Benno Lossin <y86-dev@protonmail.com>
Adds the `assume_init` function to `UniqueArc<MaybeUninit<T>>` that
unsafely assumes the value to be initialized and yields a value of type
`UniqueArc<T>`. This function is used when manually initializing the
pointee of an `UniqueArc`.
Signed-off-by: Benno Lossin <y86-dev@protonmail.com>
---
rust/kernel/sync/arc.rs | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
index f2f1c83d72ba..16ec174637b2 100644
--- a/rust/kernel/sync/arc.rs
+++ b/rust/kernel/sync/arc.rs
@@ -489,6 +489,17 @@ impl<T> UniqueArc<MaybeUninit<T>> {
/// Converts a `UniqueArc<MaybeUninit<T>>` into a `UniqueArc<T>` by writing a value into it.
pub fn write(mut self, value: T) -> UniqueArc<T> {
self.deref_mut().write(value);
+ // SAFETY: We just wrote the value to be initialized.
+ unsafe { self.assume_init() }
+ }
+
+ /// Unsafely assume that `self` is initialized.
+ ///
+ /// # Safety
+ ///
+ /// The caller guarantees that the value behind this pointer has been initialized. It is
+ /// *immediate* UB to call this when the value is not initialized.
+ pub unsafe fn assume_init(self) -> UniqueArc<T> {
let inner = ManuallyDrop::new(self).inner.ptr;
UniqueArc {
// SAFETY: The new `Arc` is taking over `ptr` from `self.inner` (which won't be
--
2.39.2
next prev parent reply other threads:[~2023-03-29 22:33 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 22:32 [PATCH v3 00/13] Rust pin-init API for pinned initialization of structs y86-dev
2023-03-29 22:32 ` [PATCH v3 01/13] rust: macros: add `quote!` macro y86-dev
2023-03-30 11:42 ` Andreas Hindborg
2023-03-30 12:01 ` Andreas Hindborg
2023-03-30 13:11 ` Gary Guo
2023-03-30 13:33 ` Alice Ryhl
2023-03-31 10:43 ` Andreas Hindborg
2023-03-29 22:32 ` y86-dev [this message]
2023-03-30 4:13 ` [PATCH v3 02/13] rust: sync: add `assume_init` to `UniqueArc` Wedson Almeida Filho
2023-03-30 12:18 ` Andreas Hindborg
2023-03-30 13:33 ` Alice Ryhl
2023-03-29 22:33 ` [PATCH v3 03/13] rust: types: add `Opaque::raw_get` y86-dev
2023-03-30 10:49 ` Gary Guo
2023-03-30 12:32 ` Andreas Hindborg
2023-03-30 13:33 ` Alice Ryhl
2023-03-29 22:33 ` [PATCH v3 04/13] rust: add pin-init API core y86-dev
2023-03-30 13:05 ` Andreas Hindborg
2023-03-30 15:46 ` Benno Lossin
2023-03-31 8:16 ` Andreas Hindborg
2023-03-30 13:17 ` Alice Ryhl
2023-03-30 13:33 ` Alice Ryhl
2023-03-30 14:16 ` Andreas Hindborg
2023-03-30 15:37 ` Benno Lossin
2023-03-30 15:36 ` Benno Lossin
2023-03-31 12:00 ` Andreas Hindborg
2023-03-29 22:33 ` [PATCH v3 05/13] rust: init: add initialization macros y86-dev
2023-03-30 14:21 ` Alice Ryhl
2023-03-30 15:38 ` Benno Lossin
2023-03-31 12:02 ` Andreas Hindborg
2023-03-29 22:33 ` [PATCH v3 06/13] rust: init/sync: add `InPlaceInit` trait to pin-initialize smart pointers y86-dev
2023-03-30 10:58 ` Gary Guo
2023-03-30 13:39 ` Andreas Hindborg
2023-03-30 14:37 ` Alice Ryhl
2023-03-30 15:28 ` Benno Lossin
2023-03-30 20:24 ` Alice Ryhl
2023-03-29 22:33 ` [PATCH v3 07/13] rust: init: add `PinnedDrop` trait and macros y86-dev
2023-03-30 11:01 ` Gary Guo
2023-03-30 15:41 ` Benno Lossin
2023-03-30 14:45 ` Alice Ryhl
2023-03-31 12:31 ` Andreas Hindborg
2023-03-29 22:33 ` [PATCH v3 08/13] rust: init: add `stack_pin_init!` macro y86-dev
2023-03-30 11:06 ` Gary Guo
2023-03-30 15:07 ` Alice Ryhl
2023-03-30 15:00 ` Alice Ryhl
2023-03-30 15:19 ` Benno Lossin
2023-03-30 20:28 ` Alice Ryhl
2023-03-31 12:43 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329223239.138757-3-y86-dev@protonmail.com \
--to=y86-dev@protonmail.com \
--cc=alex.gaynor@gmail.com \
--cc=alice@ryhl.io \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).