From: Gary Guo <gary@garyguo.net>
To: Alice Ryhl <aliceryhl@google.com>
Cc: changxian.cqs@antgroup.com, alex.gaynor@gmail.com,
benno.lossin@proton.me, bjorn3_gh@protonmail.com,
boqun.feng@gmail.com, linux-kernel@vger.kernel.org,
ojeda@kernel.org, rust-for-linux@vger.kernel.org,
sergio.collado@gmail.com, tate.thl@antgroup.com,
wedsonaf@gmail.com
Subject: Re: [PATCH 1/1] rust: macros: fix redefine const_name in `vtable`
Date: Wed, 2 Aug 2023 21:02:08 +0100 [thread overview]
Message-ID: <20230802210208.4dce7501.gary@garyguo.net> (raw)
In-Reply-To: <20230802195020.3062950-1-aliceryhl@google.com>
On Wed, 2 Aug 2023 19:50:20 +0000
Alice Ryhl <aliceryhl@google.com> wrote:
> Qingsong Chen <changxian.cqs@antgroup.com> writes:
> > let mut body_it = body.stream().into_iter();
> > - let mut functions = Vec::new();
> > + let mut functions = HashSet::new();
>
> Please use a `BTreeSet` instead of a `HashSet`. A `HashSet` has
> non-deterministic iteration order, so this will make the macro output
> different things each time you run it.
>
> Alice
>
Good point.
Another way is to just use the existing `consts` HashSet to avoid
duplication. Something like
consts.insert(gen_const_name);
after emitting the const item would probably be sufficient.
Best,
Gary
next prev parent reply other threads:[~2023-08-02 20:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 7:42 [PATCH 0/1] Fix redefine const_name in `vtable` macro Qingsong Chen
2023-06-26 7:42 ` [PATCH 1/1] rust: macros: fix redefine const_name in `vtable` Qingsong Chen
2023-06-26 16:49 ` Martin Rodriguez Reboredo
2023-06-28 9:59 ` Benno Lossin
2023-06-28 16:42 ` Gary Guo
2023-08-02 17:39 ` Miguel Ojeda
2023-08-02 17:43 ` Miguel Ojeda
2023-08-02 19:50 ` Alice Ryhl
2023-08-02 20:02 ` Gary Guo [this message]
2023-08-03 9:20 ` Qingsong Chen
2023-08-03 12:52 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802210208.4dce7501.gary@garyguo.net \
--to=gary@garyguo.net \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=changxian.cqs@antgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sergio.collado@gmail.com \
--cc=tate.thl@antgroup.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).