* Re: [PATCH] rust: error: Markdown style nit
2023-09-06 20:48 [PATCH] rust: error: Markdown style nit Manmohan Shukla
@ 2023-09-15 9:52 ` Vincenzo Palazzo
2023-09-19 11:42 ` Alice Ryhl
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Vincenzo Palazzo @ 2023-09-15 9:52 UTC (permalink / raw)
To: Manmohan Shukla, rust-for-linux; +Cc: linux-kernel
> This patch fixes a trivial markdown style nit in the `SAFETY` comment.
>
> Signed-off-by: Manmohan Shukla <manmshuk@gmail.com>
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] rust: error: Markdown style nit
2023-09-06 20:48 [PATCH] rust: error: Markdown style nit Manmohan Shukla
2023-09-15 9:52 ` Vincenzo Palazzo
@ 2023-09-19 11:42 ` Alice Ryhl
2023-09-20 13:09 ` Benno Lossin
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Alice Ryhl @ 2023-09-19 11:42 UTC (permalink / raw)
To: manmshuk; +Cc: linux-kernel, rust-for-linux
> This patch fixes a trivial markdown style nit in the `SAFETY` comment.
>
> Signed-off-by: Manmohan Shukla <manmshuk@gmail.com>
> ---
> rust/kernel/error.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 05fcab6abfe6..6233021daa8a 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -133,7 +133,7 @@ pub fn to_errno(self) -> core::ffi::c_int {
> /// Returns the error encoded as a pointer.
> #[allow(dead_code)]
> pub(crate) fn to_ptr<T>(self) -> *mut T {
> - // SAFETY: self.0 is a valid error due to its invariant.
> + // SAFETY: `self.0` is a valid error due to its invariant.
> unsafe { bindings::ERR_PTR(self.0.into()) as *mut _ }
> }
>
> --
> 2.34.1
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] rust: error: Markdown style nit
2023-09-06 20:48 [PATCH] rust: error: Markdown style nit Manmohan Shukla
2023-09-15 9:52 ` Vincenzo Palazzo
2023-09-19 11:42 ` Alice Ryhl
@ 2023-09-20 13:09 ` Benno Lossin
2023-09-20 18:05 ` Finn Behrens
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Benno Lossin @ 2023-09-20 13:09 UTC (permalink / raw)
To: Manmohan Shukla, rust-for-linux; +Cc: linux-kernel
On 06.09.23 22:48, Manmohan Shukla wrote:
> This patch fixes a trivial markdown style nit in the `SAFETY` comment.
>
> Signed-off-by: Manmohan Shukla <manmshuk@gmail.com>
> ---
> rust/kernel/error.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 05fcab6abfe6..6233021daa8a 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -133,7 +133,7 @@ pub fn to_errno(self) -> core::ffi::c_int {
> /// Returns the error encoded as a pointer.
> #[allow(dead_code)]
> pub(crate) fn to_ptr<T>(self) -> *mut T {
> - // SAFETY: self.0 is a valid error due to its invariant.
> + // SAFETY: `self.0` is a valid error due to its invariant.
> unsafe { bindings::ERR_PTR(self.0.into()) as *mut _ }
> }
>
> --
> 2.34.1
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] rust: error: Markdown style nit
2023-09-06 20:48 [PATCH] rust: error: Markdown style nit Manmohan Shukla
` (2 preceding siblings ...)
2023-09-20 13:09 ` Benno Lossin
@ 2023-09-20 18:05 ` Finn Behrens
2023-09-20 23:01 ` Andreas Hindborg (Samsung)
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Finn Behrens @ 2023-09-20 18:05 UTC (permalink / raw)
To: Manmohan Shukla; +Cc: rust-for-linux, linux-kernel
On 6 Sep 2023, at 22:48, Manmohan Shukla wrote:
> This patch fixes a trivial markdown style nit in the `SAFETY` comment.
>
> Signed-off-by: Manmohan Shukla <manmshuk@gmail.com>
> ---
Reviewed-by: Finn Behrens <me@kloenk.dev>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] rust: error: Markdown style nit
2023-09-06 20:48 [PATCH] rust: error: Markdown style nit Manmohan Shukla
` (3 preceding siblings ...)
2023-09-20 18:05 ` Finn Behrens
@ 2023-09-20 23:01 ` Andreas Hindborg (Samsung)
2023-09-21 0:24 ` Jianguo Bao
2023-10-08 20:01 ` Miguel Ojeda
6 siblings, 0 replies; 8+ messages in thread
From: Andreas Hindborg (Samsung) @ 2023-09-20 23:01 UTC (permalink / raw)
To: Manmohan Shukla; +Cc: rust-for-linux, linux-kernel
Manmohan Shukla <manmshuk@gmail.com> writes:
> This patch fixes a trivial markdown style nit in the `SAFETY` comment.
>
> Signed-off-by: Manmohan Shukla <manmshuk@gmail.com>
> ---
Reviewed-by: Andreas Hindborg <a.hindborg@samsung.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] rust: error: Markdown style nit
2023-09-06 20:48 [PATCH] rust: error: Markdown style nit Manmohan Shukla
` (4 preceding siblings ...)
2023-09-20 23:01 ` Andreas Hindborg (Samsung)
@ 2023-09-21 0:24 ` Jianguo Bao
2023-10-08 20:01 ` Miguel Ojeda
6 siblings, 0 replies; 8+ messages in thread
From: Jianguo Bao @ 2023-09-21 0:24 UTC (permalink / raw)
To: Manmohan Shukla; +Cc: rust-for-linux, linux-kernel
On Thu, Sep 07, 2023 at 02:18:57AM +0530, Manmohan Shukla wrote:
> This patch fixes a trivial markdown style nit in the `SAFETY` comment.
>
> Signed-off-by: Manmohan Shukla <manmshuk@gmail.com>
> ---
> rust/kernel/error.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 05fcab6abfe6..6233021daa8a 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -133,7 +133,7 @@ pub fn to_errno(self) -> core::ffi::c_int {
> /// Returns the error encoded as a pointer.
> #[allow(dead_code)]
> pub(crate) fn to_ptr<T>(self) -> *mut T {
> - // SAFETY: self.0 is a valid error due to its invariant.
> + // SAFETY: `self.0` is a valid error due to its invariant.
> unsafe { bindings::ERR_PTR(self.0.into()) as *mut _ }
> }
>
> --
> 2.34.1
Reviewed-by: Jianguo Bao <roidinev@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] rust: error: Markdown style nit
2023-09-06 20:48 [PATCH] rust: error: Markdown style nit Manmohan Shukla
` (5 preceding siblings ...)
2023-09-21 0:24 ` Jianguo Bao
@ 2023-10-08 20:01 ` Miguel Ojeda
6 siblings, 0 replies; 8+ messages in thread
From: Miguel Ojeda @ 2023-10-08 20:01 UTC (permalink / raw)
To: Manmohan Shukla; +Cc: rust-for-linux, linux-kernel
On Wed, Sep 6, 2023 at 10:51 PM Manmohan Shukla <manmshuk@gmail.com> wrote:
>
> This patch fixes a trivial markdown style nit in the `SAFETY` comment.
>
> Signed-off-by: Manmohan Shukla <manmshuk@gmail.com>
Applied to `rust-fixes`, thanks everyone!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 8+ messages in thread