Re: [RFC PATCH v1 4/4] sample: rust: add Asix PHY driver

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Sep 13, 2023 at 10:36:09PM +0900, FUJITA Tomonori wrote:
> +impl kernel::Module for RustAsixPhy {
> +    fn init(module: &'static ThisModule) -> Result<Self> {
> +        pr_info!("Rust Asix phy driver\n");

Meta-comment, when drivers are working properly, they are quiet.

Also, no driver should have pr_*() calls in them, they work on devices,
so the normal dev_*() calls should be used instead, if you have to print
anything out.

> +        let mut reg: phy::Registration<1> = phy::Registration::new(module);
> +
> +        reg.register(&phy::Adapter::<PhyAx88772A>::new(c_str!(
> +            "Asix Electronics AX88772A"
> +        )))?;
> +        Ok(RustAsixPhy { _reg: reg })
> +    }
> +}
> +
> +impl Drop for RustAsixPhy {
> +    fn drop(&mut self) {
> +        pr_info!("Rust Asix phy driver (exit)\n");

Again, drivers need to be quiet :)

thanks,

greg k-h