Re: [RFC PATCH v1 4/4] sample: rust: add Asix PHY driver

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Sep 13, 2023 at 08:50:18PM +0200, Andrew Lunn wrote:
> On Wed, Sep 13, 2023 at 06:53:33PM +0200, Greg KH wrote:
> > On Wed, Sep 13, 2023 at 04:11:00PM +0200, Andrew Lunn wrote:
> > > On Wed, Sep 13, 2023 at 10:36:09PM +0900, FUJITA Tomonori wrote:
> > > > This is the simpler version of drivers/net/phy/ax88796b.c. The C
> > > > driver implements three PHY drivers but this implements only one,
> > > > AX88772A PHY. This provides educational information for Rust
> > > > abstractions for network PHY drivers.
> > > 
> > > Rather than being a sample, please make it a real driver. Place it in
> > > drivers/net/phy, add a Kconfig option to select it. Maybe drop the
> > > rust_ prefix, since the .rs makes it clear what sort of file it is.
> > 
> > But note, we can not have duplicate drivers for the same hardware, so
> > the .c file needs to have the support for this device removed from it,
> > OR you need to add support for the other devices to this driver and then
> > the .c file can be removed.
> 
> I would suggest these Rust drivers support all the devices the C
> driver does, and there is some kconfig logic to make them mutually
> exclusive.

No, don't do that, it's horrid and we have been down that road in the
past and we don't want to do it again.  One driver per device please.

thanks,

greg k-h