From: Greg KH <gregkh@linuxfoundation.org>
To: Benno Lossin <benno.lossin@proton.me>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] rust: macros: allow generic parameter default values in `#[pin_data]`
Date: Sat, 25 Nov 2023 14:26:30 +0000 [thread overview]
Message-ID: <2023112525-impatient-untwist-ee3d@gregkh> (raw)
In-Reply-To: <20231125125024.1235933-2-benno.lossin@proton.me>
On Sat, Nov 25, 2023 at 12:51:09PM +0000, Benno Lossin wrote:
> This patch adds compatibilty for generic parameters defaults by using
> the newly introduced `decl_generics` instead of the `impl_generics`.
This says _what_ is happening here, but not _why_ this is needed at all.
Try taking a look a the kernel documentation for how to write a good
changelog text to make this much better. It's often times the most
difficult portion of making a kernel patch, the code is easy, writing a
summary of why everyone else should agree that this code is acceptable
is hard.
good luck!
greg k-h
next prev parent reply other threads:[~2023-11-25 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 12:50 [PATCH 1/3] rust: macros: `parse_generics` add `decl_generics` Benno Lossin
2023-11-25 12:51 ` [PATCH 2/3] rust: macros: allow generic parameter default values in `#[pin_data]` Benno Lossin
2023-11-25 14:26 ` Greg KH [this message]
2023-11-25 15:02 ` Benno Lossin
2023-11-25 15:10 ` Greg KH
2023-11-25 15:26 ` Benno Lossin
2023-11-25 16:03 ` Greg KH
2023-11-25 18:25 ` Alice Ryhl
2023-11-25 13:39 ` [PATCH 1/3] rust: macros: `parse_generics` add `decl_generics` Jarkko Sakkinen
2023-11-25 15:39 ` Benno Lossin
2023-12-02 17:33 ` Jarkko Sakkinen
2023-12-04 11:15 ` Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023112525-impatient-untwist-ee3d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).