Re: [PATCH] rust: place generated init_module() function in .init.text

[Thomas Bertschinger <tahbertschinger@gmail.com>]

On Mon, Feb 05, 2024 at 10:45:19AM +0100, Alice Ryhl wrote:
> On Sat, Feb 3, 2024 at 7:28 PM Thomas Bertschinger
> <tahbertschinger@gmail.com> wrote:
> >
> > diff --git a/rust/macros/module.rs b/rust/macros/module.rs
> > index d62d8710d77a..d09be1bee397 100644
> > --- a/rust/macros/module.rs
> > +++ b/rust/macros/module.rs
> > @@ -225,6 +225,7 @@ pub(crate) fn module(ts: TokenStream) -> TokenStream {
> >              #[cfg(MODULE)]
> >              #[doc(hidden)]
> >              #[no_mangle]
> > +            #[link_section = \".init.text\"]
> >              pub extern \"C\" fn init_module() -> core::ffi::c_int {{
> >                  __init()
> >              }}
> 
> Perhaps this function should be made unsafe? I don't think there's
> currently anything preventing safe non-init Rust code from calling it
> directly as-is.
> 
> Alice

That's a good point. That makes sense to me; I can work on a v2 that does
this.

- Thomas Bertschinger