From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B81DD25757; Tue, 27 Feb 2024 18:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709058252; cv=none; b=J6eSSz70P07fRKcRGOq8n2fckHfVqXAR1dPfhIXmDi/kntChZmZ9NRG5GAfT74qiwO1ZXU9mrYATh5Up/7yctP6WPmOyRKQJ7NW1wEEjrXYffWABvFcZy+rDl9ZhCpo60OWplYSrY8L2T1Q5l1jGECy2xZpFytACTM1k+dBQl6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709058252; c=relaxed/simple; bh=cDF3mXGEW5pin9U2a6M5esBI1SUIsMfuCrh97q573Lk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V+g9buXC7WK7xCPErO9vGORkIPqZplmJJFgbvw1nBRmaU/rSUW3Trcf6TCXkV6J4Pca/+OpcTjF4evBc2NBBn4A0sRfirtWDxpjpinomPX7s2pS8+Cu96L5zXgcbRtQ63j706r7YGpY1AYYQBtWVXyNzCUEOwUXGKEDutrYhupM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bA1hRpnB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bA1hRpnB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DB4AC433C7; Tue, 27 Feb 2024 18:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709058252; bh=cDF3mXGEW5pin9U2a6M5esBI1SUIsMfuCrh97q573Lk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bA1hRpnBJ3qCAhZXhUlSgF8QuX7KuxIqPL/kQnsGozEYJ3SfUi3/yApOT+QLPA9za TfYOGP9Y5Tdu6SlJ2yCBjSfLsFjYjme/PQZZWNfQL4Ftut0SpK2HDdBMKzEy/whZa3 PDuoNZxsv34B9Z3u49bMxr8csHUfS4SqVGjk+EIbSwWHUUSV+usGwyALtb7SV1jh15 IUspdokrAhaTrbwRawkGlPhjLjv/t2/LxG5tO3WdDSJZytnWzupKbQ62WzUPDh8R4Q W9med3/S8RjdcL5uAJc3GyqPEtV/XmdMn5xZmVah/XRnwckx/iIUNTvyVa14sK0/9H QIQp6amHKLdMQ== Date: Tue, 27 Feb 2024 18:24:06 +0000 From: Conor Dooley To: Miguel Ojeda Cc: Conor Dooley , linux-riscv@lists.infradead.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Nathan Chancellor , Nick Desaulniers , Tom Rix , rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v2 2/3] scripts: generate_rust_target: enable building on RISC-V Message-ID: <20240227-aside-limeade-497fb182a5bd@spud> References: <20240223-employee-pessimism-03ba0b58db6b@spud> <20240227-resolved-deceit-4a59a6af5b71@wendy> <20240227-glove-underwire-f562a56cf2c7@wendy> <20240227-swarm-serpent-2010b255f68a@wendy> <20240227-timothy-jailbreak-01a9c29f3607@spud> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D1EopDYvcEeT6CSG" Content-Disposition: inline In-Reply-To: --D1EopDYvcEeT6CSG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 27, 2024 at 07:11:17PM +0100, Miguel Ojeda wrote: > On Tue, Feb 27, 2024 at 6:48=E2=80=AFPM Conor Dooley w= rote: > For instance, to disable the compressed instructions, from what I can > tell, the flag I mentioned seems to work, so that is fine. To me, using flags is a good fit given that's what we do elsewhere, and there won't be a mix of stuff that is done conditionally in a script and conditionally in a Makefile. > However, > for something like tweaking the data layout for `n64` instead of > `n32:64`, I am not aware of a way to do so via a flag (but I see newer > LLVM uses `n32:64`, so that may be the better one anyway: > https://godbolt.org/z/Eh4cfdeMr). Yeah, I had looked at the blame for the targets earlier today and noticed that it had been changed. Sadly rustc's commit is lacking any justification whatsoever for the change, so I was not going to really comment on that until I had looked. > So it all depends on whether you are happy with what the flags > approach already give you. >=20 > I hope that clarifies a bit! Ye, thanks. I'll give it a go when I have a bit of time this week. --D1EopDYvcEeT6CSG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZd4oxgAKCRB4tDGHoIJi 0tm5AQDR5I+m1Asy6DGQhAa4NBVf8TGEm4mWhvmKqUunPVp7UAD/Uv/pYmT+0Zzr j8fw2SaUOY4F5yKafkbQHmmA9iYdZQQ= =qBac -----END PGP SIGNATURE----- --D1EopDYvcEeT6CSG--