Re: [PATCH 2/8] rust: device: Add a minimal RawDevice trait

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Mar 26, 2024 at 11:38:45PM +0100, Danilo Krummrich wrote:
> On Mon, Mar 25, 2024 at 07:14:17PM +0100, Greg KH wrote:
> > On Mon, Mar 25, 2024 at 06:49:06PM +0100, Danilo Krummrich wrote:
> > > From: Wedson Almeida Filho <wedsonaf@gmail.com>
> > > 
> > > Add a RawDevice trait which can be implemented by any type representing
> > > a device class (such as a PlatformDevice). This is the minimum amount of
> > > Device support code required to unblock abstractions that need to take
> > > device pointers.
> > > 
> > > Co-developed-by: Miguel Ojeda <ojeda@kernel.org>
> > > Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> > > Signed-off-by: Wedson Almeida Filho <wedsonaf@gmail.com>
> > > Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> > > ---
> > >  rust/bindings/bindings_helper.h |  1 +
> > >  rust/kernel/device.rs           | 23 +++++++++++++++++++++++
> > 
> > As fun as it is to bury .rs files down in rust/ where no one notices
> > them, I'm going to ask for this to live in drivers/base/ please so that
> > we notice it and it shows up as a first-class interface here.  Otherwise
> > it's going to be impossible to keep in sync over time.
> > 
> > Also, who is going to maintain this?  Didn't checkpatch warn you when
> > you ran it against this patch?  You did use checkpatch, right?  :)
> 
> Sure, but I left this open to discuss this intentionally.
> 
> As you might have noticed, I'm not the original author of those patches. I
> gathered them from various places (mostly the original R4L "rust" branch).
> 
> I basically figured out the dependencies, structured things in corresponding
> staging branches, fixed some issues and polished the commits; the details are
> in [1].

And it looks like you ignored the review comments from a year ago when
these were last submitted, as Wedson pointed out :(

Please, when taking code from others, be sure you are not sending stuff
that has already been rejected, that just wastes all of our time...

greg k-h