Re: [PATCH 4/8] rust: add driver abstraction

[Viresh Kumar <viresh.kumar@linaro.org>]

On 25-03-24, 18:49, Danilo Krummrich wrote:
> +/// Declares a kernel module that exposes a single driver.
> +///
> +/// It is meant to be used as a helper by other subsystems so they can more easily expose their own
> +/// macros.
> +#[macro_export]
> +macro_rules! module_driver {
> +    (<$gen_type:ident>, $driver_ops:ty, { type: $type:ty, $($f:tt)* }) => {
> +        type Ops<$gen_type> = $driver_ops;
> +        type ModuleType = $crate::driver::Module<Ops<$type>>;
> +        $crate::prelude::module! {
> +            type: ModuleType,
> +            $($f)*
> +        }
> +    }
> +}

Not a problem with this series but with the internal implementation in
rust/macros/module.rs I guess.

The "name" field for the "module_driver" currently doesn't support the
'-' symbol. That's the right thing to do for function names, init
sections, etc, but this also translates to device names and they are
allowed by the kernel to have a '-'.

-- 
viresh