From: Valentin Obst <kernel@valentinobst.de>
To: laura.nao@collabora.com
Cc: a.hindborg@samsung.com, alex.gaynor@gmail.com,
aliceryhl@google.com, benno.lossin@proton.me,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com,
dirk.behme@de.bosch.com, gary@garyguo.net,
kernel-linux@vger.kernel.org, kernel@collabora.com,
kernel@valentinobst.de, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, wedsonaf@gmail.com
Subject: Re: [PATCH] docs: rust: Add instructions for the Rust kselftest
Date: Fri, 29 Mar 2024 18:13:24 +0100 [thread overview]
Message-ID: <20240329171324.5221-1-kernel@valentinobst.de> (raw)
In-Reply-To: <20240329153025.150112-1-laura.nao@collabora.com>
> +
> +The Kselftest
> +---------------------
> +
> +A Kselftest is also available, which verifies that the Rust sample modules
> +can be added and removed correctly.
> +
> +The kernel config options required for the test are listed in the
> +tools/testing/selftests/rust/config file and can be included with the aid
> +of the merge_config.sh script::
> +
> + ./scripts/kconfig/merge_config.sh .config tools/testing/selftests/rust/config
> +
> +To build and run the test, use::
> +
> + make TARGETS="rust" kselftest
> +
In addition to what Miguel said, I think it would also be useful to
mention that kselftests are expected to be run (e.g. via the above
command) on a system that is _running_ the kernel to be tested.
I think its worth pointing that out since in that sense they are different
from the other tests on this page, for which the example command can be run
from the kernel tree on an arbitrary system. Of course that's all written
in the docs you linked, but I assume spelling it out here will avoid
confusion.
Apart from that it looks good to me.
- Best Valentin
> +Refer to Documentation/dev-tools/kselftest.rst for the general Kselftest
> +documentation.
next prev parent reply other threads:[~2024-03-29 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 15:30 [PATCH] docs: rust: Add instructions for the Rust kselftest Laura Nao
2024-03-29 16:47 ` Miguel Ojeda
2024-03-29 17:13 ` Valentin Obst [this message]
2024-04-01 12:48 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240329171324.5221-1-kernel@valentinobst.de \
--to=kernel@valentinobst.de \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dirk.behme@de.bosch.com \
--cc=gary@garyguo.net \
--cc=kernel-linux@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=laura.nao@collabora.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).