rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Roland Xu <mu001999@outlook.com>
Cc: ojeda@kernel.org, boqun.feng@gmail.com,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: kernel: make impl_has_work compatible with more complex generics
Date: Wed, 22 May 2024 16:47:11 +0200	[thread overview]
Message-ID: <2024052213-uninjured-stricken-cc20@gregkh> (raw)
In-Reply-To: <ME0P282MB489023110AAF1163F0A4B2E1CCEB2@ME0P282MB4890.AUSP282.PROD.OUTLOOK.COM>

On Wed, May 22, 2024 at 09:16:33PM +0800, Roland Xu wrote:
> Make the impl_has_work macro compatible with more complex generics such as lifetimes and const generic arguments.

Can you wrap your lines at 72 columns like checkpatch asks for?

> See more in https://github.com/Rust-for-Linux/linux/issues/1077

Please don't point to external sites for "more information", include it
here in the changelog text as this is where it is going to live for
"forever", random external sites hosted by others usually have short
lifespans.

thanks,

greg k-h

  reply	other threads:[~2024-05-22 14:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 13:16 [PATCH] rust: kernel: make impl_has_work compatible with more complex generics Roland Xu
2024-05-22 14:47 ` Greg KH [this message]
2024-05-22 15:55   ` Roland Xu
2024-05-22 15:45 ` [PATCH v2] rust: kernel: make impl_has_work compatible with more generics Roland Xu
2024-05-22 15:57   ` Greg KH
2024-05-22 16:08     ` [PATCH v3] " Roland Xu
2024-07-09  7:50       ` Miguel Ojeda
2024-05-22 16:11     ` [PATCH v2] " Roland Xu
  -- strict thread matches above, loose matches on Subject: below --
2024-05-22 12:48 [PATCH] rust: kernel: make impl_has_work compatible with more complex generics mu001999
2024-05-22 12:27 mu001999
2024-05-22 12:37 ` Alice Ryhl
2024-05-27  9:05   ` Benno Lossin
2024-05-22 12:38 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024052213-uninjured-stricken-cc20@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=boqun.feng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mu001999@outlook.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).