From: Greg KH <gregkh@linuxfoundation.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: jfalempe@redhat.com, a.hindborg@samsung.com, airlied@gmail.com,
alex.gaynor@gmail.com, benno.lossin@proton.me,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com, dakr@redhat.com,
daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
gary@garyguo.net, linux-kernel@vger.kernel.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
ojeda@kernel.org, rust-for-linux@vger.kernel.org,
tzimmermann@suse.de, wedsonaf@gmail.com
Subject: Re: [PATCH 4/4] drm/panic: Add a qr_code panic screen
Date: Thu, 4 Jul 2024 11:22:32 +0200 [thread overview]
Message-ID: <2024070407-pregnancy-hazing-add9@gregkh> (raw)
In-Reply-To: <20240704091109.1453809-1-aliceryhl@google.com>
On Thu, Jul 04, 2024 at 09:11:09AM +0000, Alice Ryhl wrote:
> As long as the above requirements are satisfied, calling
> `drm_panic_qr_generate` should never cause memory unsafety, so this is
> an appropriate list of safety requirements.
>
> (You also require that `data_len <= data_size`, but if this is violated
> you get a kernel panic which isn't a memory safety problem, so it does
> not need to be listed in the safety requirements.)
Panicing while trying to print out a panic message is not a good idea,
so enforcing this would be nice :)
thanks,
greg k-h
next prev parent reply other threads:[~2024-07-04 9:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 15:33 [PATCH 0/4] drm/panic: Add a qr_code panic screen Jocelyn Falempe
2024-07-03 15:33 ` [PATCH 1/4] drm/panic: Add integer scaling to blit() Jocelyn Falempe
2024-07-03 15:33 ` [PATCH 2/4] drm/rect: add drm_rect_overlap() Jocelyn Falempe
2024-07-03 15:34 ` [PATCH 3/4] drm/panic: simplify logo handling Jocelyn Falempe
2024-07-03 15:34 ` [PATCH 4/4] drm/panic: Add a qr_code panic screen Jocelyn Falempe
2024-07-04 9:11 ` Alice Ryhl
2024-07-04 9:22 ` Greg KH [this message]
2024-07-04 9:37 ` Alice Ryhl
2024-07-04 11:37 ` Jocelyn Falempe
2024-07-04 5:03 ` [PATCH 0/4] " Greg KH
2024-07-04 8:27 ` Miguel Ojeda
2024-07-04 8:32 ` Jocelyn Falempe
2024-07-04 9:15 ` Alice Ryhl
2024-07-04 9:18 ` Alice Ryhl
2024-07-04 9:29 ` Jocelyn Falempe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024070407-pregnancy-hazing-add9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@samsung.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jfalempe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).