rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jocelyn Falempe <jfalempe@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Miguel Ojeda <ojeda@kernel.org>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	Wedson Almeida Filho <wedsonaf@gmail.com>,
	Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
	Bjorn Roy Baron <bjorn3_gh@protonmail.com>,
	Benno Lossin <benno.lossin@proton.me>,
	Andreas Hindborg <a.hindborg@samsung.com>,
	Alice Ryhl <aliceryhl@google.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	rust-for-linux@vger.kernel.org,
	Danilo Krummrich <dakr@redhat.com>
Subject: Re: [PATCH 0/4] drm/panic: Add a qr_code panic screen
Date: Thu, 4 Jul 2024 07:03:19 +0200	[thread overview]
Message-ID: <2024070417-husked-edgy-f527@gregkh> (raw)
In-Reply-To: <20240703154309.426867-1-jfalempe@redhat.com>

On Wed, Jul 03, 2024 at 05:33:57PM +0200, Jocelyn Falempe wrote:
> This series adds a new panic screen, with the kmsg data embedded in a QR-code.
> 
> The main advantage of QR-code, is that you can copy/paste the debug data to a bug report.
> 
> The QR-code encoder is written in rust, and is very specific to drm_panic.
> The reason is that it is called in a panic handler, and thus can't allocate memory, or use locking.
> The rust code uses a few rust core API, and provides only two C entry points.
> There is no particular reason to do it in rust, I just wanted to learn rust, and see if it can work in the kernel.
> 
> If you want to see what it looks like, I've put a few screenshots here:
> https://github.com/kdj0c/panic_report/issues/1

Cool, this idea has been floating around for decades, here's the last
attempt at this back in 2014:
	https://lore.kernel.org/all/1395093587-2583-1-git-send-email-teobaluta@gmail.com/

> 
> -- 
> 
> Jocelyn
> 
> 
> Jocelyn Falempe (4):
>   drm/panic: Add integer scaling to blit()
>   drm/rect: add drm_rect_overlap()
>   drm/panic: simplify logo handling
>   drm/panic: Add a qr_code panic screen
> 
>  drivers/gpu/drm/Kconfig         |  29 +
>  drivers/gpu/drm/Makefile        |   1 +
>  drivers/gpu/drm/drm_drv.c       |   3 +
>  drivers/gpu/drm/drm_panic.c     | 338 +++++++++--
>  drivers/gpu/drm/drm_panic_qr.rs | 989 ++++++++++++++++++++++++++++++++

Wait, we can put .rs files in any directory now?  I didn't think that
worked properly yet.

thanks,

greg k-h

  parent reply	other threads:[~2024-07-04  5:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 15:33 [PATCH 0/4] drm/panic: Add a qr_code panic screen Jocelyn Falempe
2024-07-03 15:33 ` [PATCH 1/4] drm/panic: Add integer scaling to blit() Jocelyn Falempe
2024-07-03 15:33 ` [PATCH 2/4] drm/rect: add drm_rect_overlap() Jocelyn Falempe
2024-07-03 15:34 ` [PATCH 3/4] drm/panic: simplify logo handling Jocelyn Falempe
2024-07-03 15:34 ` [PATCH 4/4] drm/panic: Add a qr_code panic screen Jocelyn Falempe
2024-07-04  9:11   ` Alice Ryhl
2024-07-04  9:22     ` Greg KH
2024-07-04  9:37       ` Alice Ryhl
2024-07-04 11:37     ` Jocelyn Falempe
2024-07-04  5:03 ` Greg KH [this message]
2024-07-04  8:27   ` [PATCH 0/4] " Miguel Ojeda
2024-07-04  8:32   ` Jocelyn Falempe
2024-07-04  9:15   ` Alice Ryhl
2024-07-04  9:18 ` Alice Ryhl
2024-07-04  9:29   ` Jocelyn Falempe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024070417-husked-edgy-f527@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hindborg@samsung.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=jfalempe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=wedsonaf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).