From: Valentin Obst <kernel@valentinobst.de>
To: alexmantel93@mailbox.org
Cc: a.hindborg@samsung.com, alex.gaynor@gmail.com,
aliceryhl@google.com, benno.lossin@proton.me,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com, gary@garyguo.net,
linux-kernel@vger.kernel.org, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, wedsonaf@gmail.com
Subject: Re: [PATCH v2] rust: Implement the smart pointer `InPlaceInit` for `Arc`
Date: Wed, 24 Jul 2024 16:19:27 +0200 [thread overview]
Message-ID: <20240724141927.8232-1-kernel@valentinobst.de> (raw)
In-Reply-To: <20240719192234.330341-1-alexmantel93@mailbox.org>
[snip]
> @@ -1112,11 +1113,15 @@ unsafe fn __pinned_init(self, slot: *mut T) -> Result<(), E> {
>
> /// Smart pointer that can initialize memory in-place.
> pub trait InPlaceInit<T>: Sized {
> + /// A type might be pinned implicitly. An addtional `Pin<ImplicitlyPinned>` is useless. In
> + /// doubt, the type can just be set to `Pin<Self>`.
> + type PinnedResult;
> +
[snip]
nit: Typo 's/addtional/additional'
Apart from that, I think "When in doubt, ..." or "If in doubt, ..." are
more common choices than "In doubt, ...". But that's a question of style so
feel free to ignore this comment.
Rest looks good to me.
Best
Valentin
next prev parent reply other threads:[~2024-07-24 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 19:22 [PATCH v2] rust: Implement the smart pointer `InPlaceInit` for `Arc` Alex Mantel
2024-07-22 9:09 ` Alice Ryhl
2024-07-24 14:19 ` Valentin Obst [this message]
2024-07-25 18:06 ` Benno Lossin
2024-07-27 15:58 ` Alex Mantel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240724141927.8232-1-kernel@valentinobst.de \
--to=kernel@valentinobst.de \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=alexmantel93@mailbox.org \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).