From: Lyude Paul <lyude@redhat.com>
To: rust-for-linux@vger.kernel.org
Cc: "Danilo Krummrich" <dakr@redhat.com>,
airlied@redhat.com, "Ingo Molnar" <mingo@redhat.com>,
"Will Deacon" <will@kernel.org>,
"Waiman Long" <longman@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Aakash Sen Sharma" <aakashsensharma@gmail.com>,
"Valentin Obst" <kernel@valentinobst.de>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/3] rust: Introduce irq module
Date: Thu, 25 Jul 2024 18:27:50 -0400 [thread overview]
Message-ID: <20240725222822.1784931-2-lyude@redhat.com> (raw)
In-Reply-To: <20240725222822.1784931-1-lyude@redhat.com>
This introduces a module for dealing with interrupt-disabled contexts,
including the ability to enable and disable interrupts
(with_irqs_disabled()) - along with the ability to annotate functions as
expecting that IRQs are already disabled on the local CPU.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
rust/helpers.c | 14 +++++++++
rust/kernel/irq.rs | 74 ++++++++++++++++++++++++++++++++++++++++++++++
rust/kernel/lib.rs | 1 +
3 files changed, 89 insertions(+)
create mode 100644 rust/kernel/irq.rs
diff --git a/rust/helpers.c b/rust/helpers.c
index 87ed0a5b60990..12ac32de820b5 100644
--- a/rust/helpers.c
+++ b/rust/helpers.c
@@ -69,6 +69,20 @@ void rust_helper_spin_unlock(spinlock_t *lock)
}
EXPORT_SYMBOL_GPL(rust_helper_spin_unlock);
+unsigned long rust_helper_local_irq_save(void) {
+ unsigned long flags;
+
+ local_irq_save(flags);
+
+ return flags;
+}
+EXPORT_SYMBOL_GPL(rust_helper_local_irq_save);
+
+void rust_helper_local_irq_restore(unsigned long flags) {
+ local_irq_restore(flags);
+}
+EXPORT_SYMBOL_GPL(rust_helper_local_irq_restore);
+
void rust_helper_init_wait(struct wait_queue_entry *wq_entry)
{
init_wait(wq_entry);
diff --git a/rust/kernel/irq.rs b/rust/kernel/irq.rs
new file mode 100644
index 0000000000000..8a540bd6123f7
--- /dev/null
+++ b/rust/kernel/irq.rs
@@ -0,0 +1,74 @@
+// SPDX-License-Identifier: GPL-2.0
+
+//! Interrupt controls
+//!
+//! This module allows Rust code to control processor interrupts. [`with_irqs_disabled()`] may be
+//! used for nested disables of interrupts, whereas [`IrqDisabled`] can be used for annotating code
+//! that requires that interrupts already be disabled.
+
+use bindings;
+use core::marker::*;
+
+/// A guarantee that IRQs are disabled on this CPU
+///
+/// An [`IrqDisabled`] represents a guarantee that interrupts will remain disabled on the current CPU
+/// until the lifetime of the object ends. However, it does not disable or enable interrupts on its
+/// own - see [`with_irqs_disabled()`] for that.
+///
+/// This object has no cost at runtime (TODO: …except if whatever kernel compile-time option that
+/// would assert IRQs are enabled or not is enabled - in which case we should actually verify that
+/// they're enabled).
+///
+/// # Examples
+///
+/// If you want to ensure that a function may only be invoked within contexts where interrupts are
+/// disabled, you can do so by requiring that a reference to this type be passed. You can also
+/// create this type using unsafe code in order to indicate that it's known that interrupts are
+/// already disabled on this CPU
+///
+/// ```
+/// use kernel::irq::{IrqDisabled, disable_irqs};
+///
+/// // Requiring interrupts be disabled to call a function
+/// fn dont_interrupt_me(_irq: &IrqDisabled<'_>) { }
+///
+/// // Disabling interrupts. They'll be re-enabled once this closure completes.
+/// disable_irqs(|irq| dont_interrupt_me(&irq));
+/// ```
+pub struct IrqDisabled<'a>(PhantomData<&'a ()>);
+
+impl<'a> IrqDisabled<'a> {
+ /// Create a new [`IrqDisabled`] without disabling interrupts
+ ///
+ /// If debug assertions are enabled, this function will check that interrupts are disabled.
+ /// Otherwise, it has no cost at runtime.
+ ///
+ /// # Safety
+ ///
+ /// This function must only be called in contexts where it is already known that interrupts have
+ /// been disabled for the current CPU, as the user is making a promise that they will remain
+ /// disabled at least until this [`IrqDisabled`] is dropped.
+ pub unsafe fn new() -> Self {
+ Self(PhantomData)
+ }
+}
+
+/// Run the closure `cb` with interrupts disabled on the local CPU.
+///
+/// Interrupts will be re-enabled once the closure returns. If interrupts were already disabled on
+/// this CPU, this is a no-op.
+#[inline]
+pub fn with_irqs_disabled<T, F>(cb: F) -> T
+where
+ F: FnOnce(IrqDisabled<'_>) -> T,
+{
+ // SAFETY: FFI call with no special requirements
+ let flags = unsafe { bindings::local_irq_save() };
+
+ let ret = cb(IrqDisabled(PhantomData));
+
+ // SAFETY: `flags` comes from our previous call to local_irq_save
+ unsafe { bindings::local_irq_restore(flags) };
+
+ ret
+}
diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
index e6b7d3a80bbce..37835ccd51087 100644
--- a/rust/kernel/lib.rs
+++ b/rust/kernel/lib.rs
@@ -36,6 +36,7 @@
pub mod firmware;
pub mod init;
pub mod ioctl;
+pub mod irq;
#[cfg(CONFIG_KUNIT)]
pub mod kunit;
#[cfg(CONFIG_NET)]
--
2.45.2
next prev parent reply other threads:[~2024-07-25 22:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 22:27 [PATCH 0/3] rust: Add irq abstraction, IrqSpinLock Lyude Paul
2024-07-25 22:27 ` Lyude Paul [this message]
2024-07-26 5:39 ` [PATCH 1/3] rust: Introduce irq module Greg KH
2024-07-26 17:45 ` Lyude Paul
2024-07-26 7:23 ` Benno Lossin
2024-07-26 18:18 ` Lyude Paul
2024-07-26 19:39 ` Benno Lossin
2024-07-26 10:13 ` Trevor Gross
2024-07-26 21:21 ` Boqun Feng
2024-07-26 21:30 ` Benno Lossin
2024-07-26 21:40 ` Boqun Feng
2024-07-25 22:27 ` [PATCH 2/3] rust: sync: Introduce LockContainer trait Lyude Paul
2024-07-26 7:40 ` Benno Lossin
2024-07-26 18:20 ` Lyude Paul
2024-07-25 22:27 ` [PATCH 3/3] rust: sync: Add IrqSpinLock Lyude Paul
2024-07-26 7:48 ` Peter Zijlstra
2024-07-26 18:29 ` Lyude Paul
2024-07-26 20:21 ` Lyude Paul
2024-07-26 20:26 ` Peter Zijlstra
2024-07-27 11:21 ` kernel test robot
2024-07-26 5:39 ` [PATCH 0/3] rust: Add irq abstraction, IrqSpinLock Greg KH
2024-07-26 17:52 ` Lyude Paul
2024-07-26 18:47 ` Lyude Paul
2024-07-26 10:50 ` Trevor Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725222822.1784931-2-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=a.hindborg@samsung.com \
--cc=aakashsensharma@gmail.com \
--cc=airlied@redhat.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@redhat.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
--cc=will@kernel.org \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).