* [PATCH] kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive
@ 2024-08-06 23:35 Miguel Ojeda
2024-08-06 23:46 ` Miguel Ojeda
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Miguel Ojeda @ 2024-08-06 23:35 UTC (permalink / raw)
To: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Masahiro Yamada
Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
Andreas Hindborg, Alice Ryhl, rust-for-linux, Nathan Chancellor,
Nicolas Schier, linux-kbuild, linux-kernel, patches
When calling the `rust_is_available.sh` script, we need to make the
jobserver available to it, as commit ecab4115c44c ("kbuild: mark `rustc`
(and others) invocations as recursive") explains and did for the others.
Otherwise, we get a warning from `rustc`. Thus fix it.
Fixes: 6dc9d9ca9a72 ("kbuild: rust-analyzer: better error handling")
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 44c02a6f60a1..9a33b6063a30 100644
--- a/Makefile
+++ b/Makefile
@@ -1963,7 +1963,7 @@ tags TAGS cscope gtags: FORCE
# Protocol).
PHONY += rust-analyzer
rust-analyzer:
- $(Q)$(CONFIG_SHELL) $(srctree)/scripts/rust_is_available.sh
+ +$(Q)$(CONFIG_SHELL) $(srctree)/scripts/rust_is_available.sh
$(Q)$(MAKE) $(build)=rust $@
# Script to generate missing namespace dependencies
base-commit: de9c2c66ad8e787abec7c9d7eff4f8c3cdd28aed
--
2.46.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive
2024-08-06 23:35 [PATCH] kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive Miguel Ojeda
@ 2024-08-06 23:46 ` Miguel Ojeda
2024-08-07 11:49 ` Alice Ryhl
2024-08-09 22:10 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2024-08-06 23:46 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Alex Gaynor, Wedson Almeida Filho, Masahiro Yamada, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Alice Ryhl, rust-for-linux, Nathan Chancellor, Nicolas Schier,
linux-kbuild, linux-kernel, patches
On Wed, Aug 7, 2024 at 1:36 AM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Otherwise, we get a warning from `rustc`. Thus fix it.
To be clear, this happens (only) when calling `make` with parallel
jobs, e.g. `-j8`.
Which does not really matter for that target, but nevertheless, some
of us call `make` with jobs enabled most of the time.
Cheers,
Miguel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive
2024-08-06 23:35 [PATCH] kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive Miguel Ojeda
2024-08-06 23:46 ` Miguel Ojeda
@ 2024-08-07 11:49 ` Alice Ryhl
2024-08-09 22:10 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Alice Ryhl @ 2024-08-07 11:49 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Alex Gaynor, Wedson Almeida Filho, Masahiro Yamada, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
rust-for-linux, Nathan Chancellor, Nicolas Schier, linux-kbuild,
linux-kernel, patches
On Wed, Aug 7, 2024 at 1:36 AM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> When calling the `rust_is_available.sh` script, we need to make the
> jobserver available to it, as commit ecab4115c44c ("kbuild: mark `rustc`
> (and others) invocations as recursive") explains and did for the others.
>
> Otherwise, we get a warning from `rustc`. Thus fix it.
>
> Fixes: 6dc9d9ca9a72 ("kbuild: rust-analyzer: better error handling")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive
2024-08-06 23:35 [PATCH] kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive Miguel Ojeda
2024-08-06 23:46 ` Miguel Ojeda
2024-08-07 11:49 ` Alice Ryhl
@ 2024-08-09 22:10 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2024-08-09 22:10 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Alex Gaynor, Wedson Almeida Filho, Masahiro Yamada, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Alice Ryhl, rust-for-linux, Nathan Chancellor, Nicolas Schier,
linux-kbuild, linux-kernel, patches
On Wed, Aug 7, 2024 at 1:36 AM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> When calling the `rust_is_available.sh` script, we need to make the
> jobserver available to it, as commit ecab4115c44c ("kbuild: mark `rustc`
> (and others) invocations as recursive") explains and did for the others.
>
> Otherwise, we get a warning from `rustc`. Thus fix it.
>
> Fixes: 6dc9d9ca9a72 ("kbuild: rust-analyzer: better error handling")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Applied to `rust-fixes` -- thanks everyone!
[ Reworded to add a couple more details mentioned in the list. - Miguel ]
Cheers,
Miguel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-09 22:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-06 23:35 [PATCH] kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive Miguel Ojeda
2024-08-06 23:46 ` Miguel Ojeda
2024-08-07 11:49 ` Alice Ryhl
2024-08-09 22:10 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).