rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pierre Gondois <pierre.gondois@arm.com>
Cc: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
	linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Robert Moore" <robert.moore@intel.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Wedson Almeida Filho" <wedsonaf@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@samsung.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
	"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
	"Thomas Bertschinger" <tahbertschinger@gmail.com>,
	"Danilo Krummrich" <dakr@redhat.com>,
	linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
	acpica-devel@lists.linux.dev, rust-for-linux@vger.kernel.org,
	"Metin Kaya" <metin.kaya@arm.com>
Subject: Re: [RFC PATCH 6/6] rust: cpufreq: Add rust implementation of cppc_cpufreq driver
Date: Fri, 16 Aug 2024 09:06:36 +0200	[thread overview]
Message-ID: <2024081634-excluding-squeezing-c386@gregkh> (raw)
In-Reply-To: <1605d622-faf5-4535-bd71-ba514ee102dd@arm.com>

On Fri, Aug 16, 2024 at 08:59:22AM +0200, Pierre Gondois wrote:
> Hello Greg, Miguel,
> 
> On 8/15/24 15:04, Miguel Ojeda wrote:
> > On Thu, Aug 15, 2024 at 10:31 AM Pierre Gondois <pierre.gondois@arm.com> wrote:
> > > 
> > > In an effort to add test/support the cpufreq framework in rust,
> > > add a rust implementation of the cppc_cpufreq driver named:
> > > `rcppc_cpufreq`.
> > 
> > Similar to what Greg said -- is this intended to be something like a
> > "Rust reference driver" [1] for the subsystem?
> 
> The initial intent was to review/test Viresh's patchset [1]. I then
> thought it would be a good idea to implement another cpufreq driver
> to see if the provided interface would work.
> As the cpufreq-dt driver is re-implemented in Viresh's patchset,
> I thought it was also ok to have this driver.

Duplicate drivers for the same hardware are never a good idea, we need
to learn from our past mistakes when we have done this before (hint, it
did not work out and we ended up dropping the duplicates.)

However, if the subsystem maintainer agrees, they are free to have
duplicate drivers, as long as the maintainer of the "new" one will be
there to help out with all of the confusion and problems that users and
distros will have :)

good luck!

greg k-h

      reply	other threads:[~2024-08-16  7:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15  8:29 [RFC PATCH 0/6] rust: cpufreq: Add cppc_cpufreq driver implementation Pierre Gondois
2024-08-15  8:29 ` [RFC PATCH 1/6] ACPI: CPPC: Move struct cppc_cpudata to cppc_cpufreq driver Pierre Gondois
2024-08-15  8:29 ` [RFC PATCH 2/6] cpufreq: cppc: Remove perf_fb_ctrs field from struct cppc_cpudata Pierre Gondois
2024-08-15  8:29 ` [RFC PATCH 3/6] rust: module: Allow modules to specify initcall section Pierre Gondois
2024-08-15  8:29 ` [RFC PATCH 4/6] rust: cpufreq: Add methods to struct Cpufreq Pierre Gondois
2024-08-15  8:29 ` [RFC PATCH 5/6] rust: bindings: Add bindings for rcppc_cpufreq driver Pierre Gondois
2024-08-15  8:29 ` [RFC PATCH 6/6] rust: cpufreq: Add rust implementation of cppc_cpufreq driver Pierre Gondois
2024-08-15  9:24   ` Greg KH
2024-08-15 13:04   ` Miguel Ojeda
2024-08-16  6:59     ` Pierre Gondois
2024-08-16  7:06       ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024081634-excluding-squeezing-c386@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hindborg@samsung.com \
    --cc=acpica-devel@lists.linux.dev \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@redhat.com \
    --cc=fujita.tomonori@gmail.com \
    --cc=gary@garyguo.net \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=metin.kaya@arm.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=ojeda@kernel.org \
    --cc=pierre.gondois@arm.com \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tahbertschinger@gmail.com \
    --cc=viresh.kumar@linaro.org \
    --cc=wedsonaf@gmail.com \
    --cc=yakoyoku@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).