From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34DE078C68; Fri, 16 Aug 2024 07:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723792000; cv=none; b=Oou9XUrHZdtHN8tpvQsmo2zg76IqnpYZGwtwcw+RovvlMDP4cTZxVcPtEEKy6LxNREcQYUPLN4rJZsXpkenmWyNhtsYkWRAfQYLV0ORzL6KaDhUEuDHTR4a9WBmJry9P7su/k8VY0YfhaY+4YI4ew3yBJ2WloCK0vLzvCilaBYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723792000; c=relaxed/simple; bh=3J0NRytEsTukDgVOmZIAUw6cxnJT3AnHuFYMxFXR5/4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JlSoQyu8MuMHxQ2CzQVW3gJNAFcn14mY+CDoyyJhFoUMesv/fjCJ6xawBnQ5veXy6wKf0y5ThfK3WDJpjpvV9/uwiGZ7yzXJpH/ev38bcs94qa0XE8EAFAbourbCR0zUYPh9aieeLJzNKI2sxMQZiAqpH2R7lImLqTDN3BqyRqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kfPWJs8z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kfPWJs8z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F8D4C32782; Fri, 16 Aug 2024 07:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723791999; bh=3J0NRytEsTukDgVOmZIAUw6cxnJT3AnHuFYMxFXR5/4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kfPWJs8zN3LV+ovFZqYb0GyUraQ71cmPjiIK6tzsmYps0Y3h8KC8jP0BSNEGa85If PA1nwWfnYzoUpg4qZOog9cj+0KVJ5pan7CmMu9PFVrSCwwleavd29aHezUmAHAezBV S0637v2hVxRNlGTV4O6/xJtFEo3ERTxShj5VhqMM= Date: Fri, 16 Aug 2024 09:06:36 +0200 From: Greg Kroah-Hartman To: Pierre Gondois Cc: Miguel Ojeda , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Viresh Kumar , Robert Moore , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Martin Rodriguez Reboredo , Manos Pitsidianakis , Mika Westerberg , FUJITA Tomonori , Thomas Bertschinger , Danilo Krummrich , linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, acpica-devel@lists.linux.dev, rust-for-linux@vger.kernel.org, Metin Kaya Subject: Re: [RFC PATCH 6/6] rust: cpufreq: Add rust implementation of cppc_cpufreq driver Message-ID: <2024081634-excluding-squeezing-c386@gregkh> References: <20240815082916.1210110-1-pierre.gondois@arm.com> <20240815082916.1210110-7-pierre.gondois@arm.com> <1605d622-faf5-4535-bd71-ba514ee102dd@arm.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1605d622-faf5-4535-bd71-ba514ee102dd@arm.com> On Fri, Aug 16, 2024 at 08:59:22AM +0200, Pierre Gondois wrote: > Hello Greg, Miguel, > > On 8/15/24 15:04, Miguel Ojeda wrote: > > On Thu, Aug 15, 2024 at 10:31 AM Pierre Gondois wrote: > > > > > > In an effort to add test/support the cpufreq framework in rust, > > > add a rust implementation of the cppc_cpufreq driver named: > > > `rcppc_cpufreq`. > > > > Similar to what Greg said -- is this intended to be something like a > > "Rust reference driver" [1] for the subsystem? > > The initial intent was to review/test Viresh's patchset [1]. I then > thought it would be a good idea to implement another cpufreq driver > to see if the provided interface would work. > As the cpufreq-dt driver is re-implemented in Viresh's patchset, > I thought it was also ok to have this driver. Duplicate drivers for the same hardware are never a good idea, we need to learn from our past mistakes when we have done this before (hint, it did not work out and we ended up dropping the duplicates.) However, if the subsystem maintainer agrees, they are free to have duplicate drivers, as long as the maintainer of the "new" one will be there to help out with all of the confusion and problems that users and distros will have :) good luck! greg k-h