From: Jakub Kicinski <kuba@kernel.org>
To: Trevor Gross <tmgross@umich.edu>
Cc: FUJITA Tomonori <fujita.tomonori@gmail.com>,
netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
andrew@lunn.ch, miguel.ojeda.sandonis@gmail.com,
benno.lossin@proton.me, aliceryhl@google.com
Subject: Re: [PATCH net-next v7 4/6] rust: net::phy unified read/write API for C22 and C45 registers
Date: Tue, 27 Aug 2024 14:14:14 -0700 [thread overview]
Message-ID: <20240827141414.5df849d5@kernel.org> (raw)
In-Reply-To: <CALNs47uSeGR_Z_Bor4yKbd848XdohHMam47zwBct39nEmKFb7g@mail.gmail.com>
On Sat, 24 Aug 2024 00:44:50 -0500 Trevor Gross wrote:
> Small suggestion: I think these could all be `#[derive(Clone, Copy,
> Debug)]` so they are easy to `pr_info!(...)`. C45 doesn't have any
> derives.
>
> This could probably be done when it is picked up if there isn't another version.
Please respin, it's not too much work. It's really rare that'd edit
people's code when applying in networking. The commit message yes
but code very rarely.
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-27 21:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 2:06 [PATCH net-next v7 0/6] net: phy: add Applied Micro QT2025 PHY driver FUJITA Tomonori
2024-08-24 2:06 ` [PATCH net-next v7 1/6] rust: sizes: add commonly used constants FUJITA Tomonori
2024-08-24 2:06 ` [PATCH net-next v7 2/6] rust: net::phy support probe callback FUJITA Tomonori
2024-08-24 2:06 ` [PATCH net-next v7 3/6] rust: net::phy implement AsRef<kernel::device::Device> trait FUJITA Tomonori
2024-08-24 2:06 ` [PATCH net-next v7 4/6] rust: net::phy unified read/write API for C22 and C45 registers FUJITA Tomonori
2024-08-24 5:44 ` Trevor Gross
2024-08-27 21:14 ` Jakub Kicinski [this message]
2024-08-28 7:48 ` FUJITA Tomonori
2024-08-24 2:06 ` [PATCH net-next v7 5/6] rust: net::phy unified genphy_read_status function " FUJITA Tomonori
2024-08-24 2:06 ` [PATCH net-next v7 6/6] net: phy: add Applied Micro QT2025 PHY driver FUJITA Tomonori
2024-08-24 5:32 ` Trevor Gross
2024-08-26 1:24 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827141414.5df849d5@kernel.org \
--to=kuba@kernel.org \
--cc=aliceryhl@google.com \
--cc=andrew@lunn.ch \
--cc=benno.lossin@proton.me \
--cc=fujita.tomonori@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).