From: Patrick Miller <paddymills@proton.me>
To: a.hindborg@samsung.com, alex.gaynor@gmail.com,
aliceryhl@google.com, apw@canonical.com, benno.lossin@proton.me,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com,
dwaipayanray1@gmail.com, gary@garyguo.net, joe@perches.com,
linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com,
ojeda@kernel.org, rust-for-linux@vger.kernel.org,
tmgross@umich.edu, wedsonaf@gmail.com
Cc: Patrick Miller <paddymills@proton.me>
Subject: [PATCH 2/2] checkpatch: warn on known non-plural rust doc headers
Date: Fri, 06 Sep 2024 16:45:49 +0000 [thread overview]
Message-ID: <20240906164543.2268973-1-paddymills@proton.me> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1173 bytes --]
Adds a check for documentation in rust file. Warns if certain known
documentation headers are not plural.
Signed-off-by: Patrick Miller <paddymills@proton.me>
Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1110
---
scripts/checkpatch.pl | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 39032224d504..0e99d11eeb04 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3900,6 +3900,14 @@ sub process {
"Avoid using '.L' prefixed local symbol names for denoting a range of code via 'SYM_*_START/END' annotations; see Documentation/core-api/asm-annotations.rst\n" . $herecurr);
}
+# check that document section headers are plural in rust files
+ if ( $realfile =~ /\.rs$/
+ && $rawline =~ /^\+\s*\/\/\/\s+#+\s+(Example|Invariant)\s*$/ )
+ {
+ WARN( "RUST_DOC_HEADER",
+ "Rust doc he
aders should be plural\n" . $herecurr );
+ }
+
# check we are in a valid source file C or perl if not then ignore this hunk
next if ($realfile !~ /\.(h|c|pl|dtsi|dts)$/);
--
2.46.0
[-- Attachment #1.2: publickey - paddymills@proton.me - 0xDCA74891.asc --]
[-- Type: application/pgp-keys, Size: 705 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]
next reply other threads:[~2024-09-06 16:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 16:45 Patrick Miller [this message]
2024-09-06 17:00 ` [PATCH 2/2] checkpatch: warn on known non-plural rust doc headers Greg KH
2024-09-06 17:29 ` Patrick Miller
2024-09-06 17:56 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2024-09-06 18:05 Patrick Miller
2024-09-07 10:53 ` Joe Perches
2024-09-07 11:57 ` Patrick Miller
2024-09-07 14:22 ` Patrick Miller
2024-09-07 15:33 ` Joe Perches
2024-09-09 16:24 ` Benno Lossin
2024-09-09 16:31 ` Benno Lossin
2024-09-09 16:38 ` Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906164543.2268973-1-paddymills@proton.me \
--to=paddymills@proton.me \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apw@canonical.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=gary@garyguo.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).