From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0F701B7917; Wed, 11 Sep 2024 20:07:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726085226; cv=none; b=WaTG8NMX3P34SZTdysaDzx1fkf1canTKGMUg257e5RIeMLPDUQdiZjn4QfYBeJz441f4HWp3Fv2NLA55mZ027yqlFkjf1mm8is2lDnDjAHiJN+uooJ8ErIDfkSTYx9yuUzJgLhCBwG8WigYfPp5VOzvRRo2Jd1rGt6nn5FdR5iw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726085226; c=relaxed/simple; bh=I4BJLT6G+F0wLdMtohFskrraQnFUUj6Fg5Q8+RwPmXk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mImakz/OzbtyVUZyTOM78aMchaiZ/AaFs6klam+zJO9p/xKmR6+0Z7lVPeibmNcxspkH1ZCsMwM2HQjy0Y91dr/D3r94XAFvKtMW4aEAGXisJ3QZXa0RVQ6Ud2BkuLRGMhv+xX45Oh7TcAR+6auYHpz/IY5bfpXkuT8ErrybDRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uaeL/Img; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uaeL/Img" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1A8DC4CEC0; Wed, 11 Sep 2024 20:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1726085225; bh=I4BJLT6G+F0wLdMtohFskrraQnFUUj6Fg5Q8+RwPmXk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uaeL/Img29qakLFRIxlhJcVZNDw7mlRWB+nv0ap2MGT+YdM3gXm0oEgSWfozHa+Lx XvJ6mdoLIh2WXW0OdkMo2ojZGuTvOwq/M/inTuZEwj6wwut+FnmPuJgVrwcPjCBZz2 O6jenm5DjSaqhX9tsVcV8tb3RnFMWI2LlwYcDDzY= Date: Wed, 11 Sep 2024 22:07:02 +0200 From: Greg Kroah-Hartman To: Danilo Krummrich Cc: Ayush Singh , fabien.parent@linaro.org, d-gole@ti.com, lorforlinux@beagleboard.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, Andrew Davis , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/8] rust: kernel: Add Platform device and driver abstractions Message-ID: <2024091158-cardinal-theorize-6efe@gregkh> References: <20240911-mikrobus-dt-v1-0-3ded4dc879e7@beagleboard.org> <20240911-mikrobus-dt-v1-1-3ded4dc879e7@beagleboard.org> <2024091106-scouring-smitten-e740@gregkh> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Sep 11, 2024 at 07:35:35PM +0200, Danilo Krummrich wrote: > On Wed, Sep 11, 2024 at 04:56:14PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 11, 2024 at 07:57:18PM +0530, Ayush Singh wrote: > > > +/// An identifier for Platform devices. > > > +/// > > > +/// Represents the kernel's [`struct of_device_id`]. This is used to find an appropriate > > > +/// Platform driver. > > > +/// > > > +/// [`struct of_device_id`]: srctree/include/linux/mod_devicetable.h > > > +pub struct DeviceId(&'static CStr); > > > + > > > +impl DeviceId { > > > > > > > > I appreciate posting this, but this really should go on top of the > > device driver work Danilo Krummrich has been doing. > > If everyone agrees, I'd offer to just provide platform device / driver > abstractions with my next patch series. This way you don't need to worry > about aligning things with the rest of the abstractions yourself and throughout > potential further versions of the series. That sounds good to me, thanks! > Just be aware that I probably won't get to work on it until after LPC. We will not be able to review anything until after LPC either :) thanks, greg k-h