Rust for Linux List
 help / color / mirror / Atom feed
From: Gary Guo <gary@garyguo.net>
To: Filipe Xavier <felipe_life@live.com>
Cc: aliceryhl@google.com, ojeda@kernel.org, boqun.feng@gmail.com,
	alex.gaynor@gmail.com, benno.lossin@proton.me,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v3] rust: error: make conversion functions public
Date: Fri, 13 Sep 2024 14:29:41 +0100	[thread overview]
Message-ID: <20240913142941.65fd5abd@eugeo> (raw)
In-Reply-To: <DM4PR14MB7276E6948E67B3B23D8EA847E9652@DM4PR14MB7276.namprd14.prod.outlook.com>

On Fri, 13 Sep 2024 07:19:56 -0300
Filipe Xavier <felipe_life@live.com> wrote:

> Change visibility to public of functions in error.rs:
> from_err_ptr, from_errno, from_result and to_ptr. 
> Additionally, remove dead_code annotations.
> 
> Link: https://github.com/Rust-for-Linux/linux/issues/1105
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Signed-off-by: Filipe Xavier <felipe_life@live.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> 
> ---
>  rust/kernel/error.rs | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)

  parent reply	other threads:[~2024-09-13 13:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 10:19 [PATCH v3] rust: error: make conversion functions public Filipe Xavier
2024-09-13 10:26 ` Benno Lossin
2024-09-13 13:29 ` Gary Guo [this message]
2024-10-03 21:49 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913142941.65fd5abd@eugeo \
    --to=gary@garyguo.net \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=boqun.feng@gmail.com \
    --cc=felipe_life@live.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox