From: Greg KH <gregkh@linuxfoundation.org>
To: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Cc: rafael@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, aliceryhl@google.com, mcgrof@kernel.org,
russ.weight@linux.dev, dakr@redhat.com, a.hindborg@kernel.org,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] device: rust: change the name function
Date: Mon, 30 Sep 2024 15:00:57 +0200 [thread overview]
Message-ID: <2024093014-endnote-swapping-6626@gregkh> (raw)
In-Reply-To: <20240930123957.49181-2-trintaeoitogc@gmail.com>
On Mon, Sep 30, 2024 at 09:39:56AM -0300, Guilherme Giacomo Simoes wrote:
> This function increment the refcount by this command "bindings::get_device(prt)".
> This can be confuse becuase, the function Arc::from_raw() from standard library, don't increment the refcount.
> Then, this function "Device::from_raw()" will be renamed for don't make confusing in the future.
Your editor should have asked you to wrap these at 72 columns, can you
please do that?
>
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
> ---
> rust/kernel/device.rs | 2 +-
> rust/kernel/firmware.rs | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
What changed from v1? That should go under the --- line.
thanks,
greg k-h
next prev parent reply other threads:[~2024-09-30 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 12:39 [PATCH v2 0/1] device: rust: change the name function Guilherme Giacomo Simoes
2024-09-30 12:39 ` [PATCH v2 1/1] " Guilherme Giacomo Simoes
2024-09-30 13:00 ` Greg KH [this message]
2024-09-30 13:13 ` Danilo Krummrich
2024-09-30 13:52 ` Guilherme Giácomo Simões
2024-09-30 15:01 ` Danilo Krummrich
2024-09-30 16:53 ` Guilherme Giácomo Simões
2024-09-30 17:02 ` Danilo Krummrich
2024-09-30 13:00 ` [PATCH v2 0/1] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024093014-endnote-swapping-6626@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@redhat.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=trintaeoitogc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).