rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Thomas Böhler" <witcher@wiredspace.de>
To: Miguel Ojeda <ojeda@kernel.org>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	Jocelyn Falempe <jfalempe@redhat.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	rust-for-linux@vger.kernel.org,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Thomas Böhler" <witcher@wiredspace.de>
Subject: [PATCH 5/7] drm/panic: correctly indent continuation of line in list item
Date: Sat, 12 Oct 2024 09:52:48 +0200	[thread overview]
Message-ID: <20241012075312.16342-5-witcher@wiredspace.de> (raw)
In-Reply-To: <20241012075312.16342-1-witcher@wiredspace.de>

It is common practice in Rust to indent the next line the same amount of
space as the previous one if both belong to the same list item. Clippy
checks for this with the lint `doc_lazy_continuation`.

error: doc list item without indentation
   --> drivers/gpu/drm/drm_panic_qr.rs:979:5
    |
979 | /// conversion to numeric segments.
    |     ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
    = note: `-D clippy::doc-lazy-continuation` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::doc_lazy_continuation)]`
help: indent this line
    |
979 | ///   conversion to numeric segments.
    |     ++

Indent the offending line by 2 more spaces to remove this Clippy error.

Reported-by: Miguel Ojeda <ojeda@kernel.org>
Closes: https://github.com/Rust-for-Linux/linux/issues/1123
Signed-off-by: Thomas Böhler <witcher@wiredspace.de>
---
 drivers/gpu/drm/drm_panic_qr.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs
index 5b2386a515fa..58c46f366f76 100644
--- a/drivers/gpu/drm/drm_panic_qr.rs
+++ b/drivers/gpu/drm/drm_panic_qr.rs
@@ -976,7 +976,7 @@ fn draw_all(&mut self, data: impl Iterator<Item = u8>) {
 /// * `url_len`: Length of the URL.
 ///
 /// * If `url_len` > 0, remove the 2 segments header/length and also count the
-/// conversion to numeric segments.
+///   conversion to numeric segments.
 /// * If `url_len` = 0, only removes 3 bytes for 1 binary segment.
 #[no_mangle]
 pub extern "C" fn drm_panic_qr_max_data_size(version: u8, url_len: usize) -> usize {
-- 
2.46.2


  parent reply	other threads:[~2024-10-12  7:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-12  7:52 [PATCH 1/7] drm/panic: avoid reimplementing Iterator::find Thomas Böhler
2024-10-12  7:52 ` [PATCH 2/7] drm/panic: remove unnecessary borrow in alignment_pattern Thomas Böhler
2024-10-14  8:45   ` Jocelyn Falempe
2024-10-12  7:52 ` [PATCH 3/7] drm/panic: prefer eliding lifetimes Thomas Böhler
2024-10-14  8:46   ` Jocelyn Falempe
2024-10-12  7:52 ` [PATCH 4/7] drm/panic: remove redundant field when assigning value Thomas Böhler
2024-10-14  8:46   ` Jocelyn Falempe
2024-10-12  7:52 ` Thomas Böhler [this message]
2024-10-14  8:47   ` [PATCH 5/7] drm/panic: correctly indent continuation of line in list item Jocelyn Falempe
2024-10-12  7:52 ` [PATCH 6/7] drm/panic: allow verbose boolean for clarity Thomas Böhler
2024-10-14  8:27   ` Alice Ryhl
2024-10-14  8:28   ` Alice Ryhl
2024-10-14  8:54   ` Jocelyn Falempe
2024-10-14 16:59     ` Miguel Ojeda
2024-10-14 19:23       ` Jocelyn Falempe
2024-10-12  7:52 ` [PATCH 7/7] drm/panic: allow verbose version check Thomas Böhler
2024-10-12 11:08   ` Miguel Ojeda
2024-10-14  8:55   ` Jocelyn Falempe
2024-10-12 11:04 ` [PATCH 1/7] drm/panic: avoid reimplementing Iterator::find Miguel Ojeda
2024-10-14  9:06   ` Jocelyn Falempe
2024-10-19  7:46     ` Thomas Böhler
2024-10-19  7:45   ` Thomas Böhler
2024-10-14  8:44 ` Jocelyn Falempe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241012075312.16342-5-witcher@wiredspace.de \
    --to=witcher@wiredspace.de \
    --cc=a.hindborg@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=jfalempe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).