From: "Thomas Böhler" <witcher@wiredspace.de>
To: Miguel Ojeda <ojeda@kernel.org>,
Alex Gaynor <alex.gaynor@gmail.com>,
Jocelyn Falempe <jfalempe@redhat.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Thomas Böhler" <witcher@wiredspace.de>
Subject: [PATCH 6/7] drm/panic: allow verbose boolean for clarity
Date: Sat, 12 Oct 2024 09:52:49 +0200 [thread overview]
Message-ID: <20241012075312.16342-6-witcher@wiredspace.de> (raw)
In-Reply-To: <20241012075312.16342-1-witcher@wiredspace.de>
Clippy complains about a non-minimal boolean expression with
`nonminimal_bool`:
error: this boolean expression can be simplified
--> drivers/gpu/drm/drm_panic_qr.rs:722:9
|
722 | (x < 8 && y < 8) || (x < 8 && y >= end) || (x >= end && y < 8)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
= note: `-D clippy::nonminimal-bool` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::nonminimal_bool)]`
help: try
|
722 | !(x >= 8 || y >= 8 && y < end) || (x >= end && y < 8)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
722 | (y >= end || y < 8) && x < 8 || (x >= end && y < 8)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
While this can be useful in a lot of cases, it isn't here because the
line expresses clearly what the intention is. Simplifying the expression
means losing clarity, so opt-out of this lint for the offending line.
Reported-by: Miguel Ojeda <ojeda@kernel.org>
Closes: https://github.com/Rust-for-Linux/linux/issues/1123
Signed-off-by: Thomas Böhler <witcher@wiredspace.de>
---
drivers/gpu/drm/drm_panic_qr.rs | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs
index 58c46f366f76..226107c02679 100644
--- a/drivers/gpu/drm/drm_panic_qr.rs
+++ b/drivers/gpu/drm/drm_panic_qr.rs
@@ -719,7 +719,8 @@ fn draw_finders(&mut self) {
fn is_finder(&self, x: u8, y: u8) -> bool {
let end = self.width - 8;
- (x < 8 && y < 8) || (x < 8 && y >= end) || (x >= end && y < 8)
+ #[allow(clippy::nonminimal_bool)]
+ return (x < 8 && y < 8) || (x < 8 && y >= end) || (x >= end && y < 8);
}
// Alignment pattern: 5x5 squares in a grid.
--
2.46.2
next prev parent reply other threads:[~2024-10-12 7:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 7:52 [PATCH 1/7] drm/panic: avoid reimplementing Iterator::find Thomas Böhler
2024-10-12 7:52 ` [PATCH 2/7] drm/panic: remove unnecessary borrow in alignment_pattern Thomas Böhler
2024-10-14 8:45 ` Jocelyn Falempe
2024-10-12 7:52 ` [PATCH 3/7] drm/panic: prefer eliding lifetimes Thomas Böhler
2024-10-14 8:46 ` Jocelyn Falempe
2024-10-12 7:52 ` [PATCH 4/7] drm/panic: remove redundant field when assigning value Thomas Böhler
2024-10-14 8:46 ` Jocelyn Falempe
2024-10-12 7:52 ` [PATCH 5/7] drm/panic: correctly indent continuation of line in list item Thomas Böhler
2024-10-14 8:47 ` Jocelyn Falempe
2024-10-12 7:52 ` Thomas Böhler [this message]
2024-10-14 8:27 ` [PATCH 6/7] drm/panic: allow verbose boolean for clarity Alice Ryhl
2024-10-14 8:28 ` Alice Ryhl
2024-10-14 8:54 ` Jocelyn Falempe
2024-10-14 16:59 ` Miguel Ojeda
2024-10-14 19:23 ` Jocelyn Falempe
2024-10-12 7:52 ` [PATCH 7/7] drm/panic: allow verbose version check Thomas Böhler
2024-10-12 11:08 ` Miguel Ojeda
2024-10-14 8:55 ` Jocelyn Falempe
2024-10-12 11:04 ` [PATCH 1/7] drm/panic: avoid reimplementing Iterator::find Miguel Ojeda
2024-10-14 9:06 ` Jocelyn Falempe
2024-10-19 7:46 ` Thomas Böhler
2024-10-19 7:45 ` Thomas Böhler
2024-10-14 8:44 ` Jocelyn Falempe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241012075312.16342-6-witcher@wiredspace.de \
--to=witcher@wiredspace.de \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jfalempe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).