[PATCH] rust: miscdevice: fix warning on c_uint to u32 cast

[PATCH] rust: miscdevice: fix warning on c_uint to u32 cast

[Alice Ryhl]

When building miscdevice with clippy warnings, the following warning is
emitted:

	warning: casting to the same type is unnecessary (`u32` -> `u32`)
	   --> /home/aliceryhl/rust-for-linux/rust/kernel/miscdevice.rs:220:28
	    |
	220 |     match T::ioctl(device, cmd as u32, arg as usize) {
	    |                            ^^^^^^^^^^ help: try: `cmd`
	    |
	    = help: for further information visit
	      https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
	    = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
	    = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_cast)]`

Thus, fix it.

Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
This fixes a warning on my patches in char-misc-next. Greg, can you take
this through that tree?
---
 rust/kernel/miscdevice.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
index cbd5249b5b45..50885fb511bf 100644
--- a/rust/kernel/miscdevice.rs
+++ b/rust/kernel/miscdevice.rs
@@ -217,7 +217,7 @@ impl<T: MiscDevice> VtableHelper<T> {
     // SAFETY: Ioctl calls can borrow the private data of the file.
     let device = unsafe { <T::Ptr as ForeignOwnable>::borrow(private) };
 
-    match T::ioctl(device, cmd as u32, arg as usize) {
+    match T::ioctl(device, cmd, arg as usize) {
         Ok(ret) => ret as c_long,
         Err(err) => err.to_errno() as c_long,
     }
@@ -234,7 +234,7 @@ impl<T: MiscDevice> VtableHelper<T> {
     // SAFETY: Ioctl calls can borrow the private data of the file.
     let device = unsafe { <T::Ptr as ForeignOwnable>::borrow(private) };
 
-    match T::compat_ioctl(device, cmd as u32, arg as usize) {
+    match T::compat_ioctl(device, cmd, arg as usize) {
         Ok(ret) => ret as c_long,
         Err(err) => err.to_errno() as c_long,
     }

---
base-commit: 619325ca7abbef5d7d7869f331b8672b6fb4513f
change-id: 20241015-miscdevice-cint-cast-3a9a023ac375

Best regards,
-- 
Alice Ryhl <aliceryhl@google.com>

Re: [PATCH] rust: miscdevice: fix warning on c_uint to u32 cast

[Greg Kroah-Hartman]

On Tue, Oct 15, 2024 at 02:13:22PM +0000, Alice Ryhl wrote:
> When building miscdevice with clippy warnings, the following warning is
> emitted:
> 
> 	warning: casting to the same type is unnecessary (`u32` -> `u32`)
> 	   --> /home/aliceryhl/rust-for-linux/rust/kernel/miscdevice.rs:220:28
> 	    |
> 	220 |     match T::ioctl(device, cmd as u32, arg as usize) {
> 	    |                            ^^^^^^^^^^ help: try: `cmd`
> 	    |
> 	    = help: for further information visit
> 	      https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
> 	    = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
> 	    = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_cast)]`
> 
> Thus, fix it.
> 
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> This fixes a warning on my patches in char-misc-next. Greg, can you take
> this through that tree?

Will do, thanks!

greg k-h

Re: [PATCH] rust: miscdevice: fix warning on c_uint to u32 cast

[Alice Ryhl]

On Tue, Oct 15, 2024 at 7:08 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Oct 15, 2024 at 02:13:22PM +0000, Alice Ryhl wrote:
> > When building miscdevice with clippy warnings, the following warning is
> > emitted:
> >
> >       warning: casting to the same type is unnecessary (`u32` -> `u32`)
> >          --> /home/aliceryhl/rust-for-linux/rust/kernel/miscdevice.rs:220:28
> >           |
> >       220 |     match T::ioctl(device, cmd as u32, arg as usize) {
> >           |                            ^^^^^^^^^^ help: try: `cmd`
> >           |
> >           = help: for further information visit
> >             https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
> >           = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
> >           = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_cast)]`
> >
> > Thus, fix it.
> >
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> > ---
> > This fixes a warning on my patches in char-misc-next. Greg, can you take
> > this through that tree?
>
> Will do, thanks!

Awesome, thanks!