From: Tamir Duberstein <tamird@gmail.com>
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Tamir Duberstein <tamird@gmail.com>
Subject: [PATCH] rust: arc: remove unused PhantomData
Date: Mon, 04 Nov 2024 17:23:44 -0400 [thread overview]
Message-ID: <20241104-simplify-arc-v1-1-a4ffc290f905@gmail.com> (raw)
There's no need for this. The type had the same form when it was first
introduced, so it seems this was never necessary.
Fixed: 9dc043655003 ("rust: sync: add `Arc` for ref-counted allocations")
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
rust/kernel/sync/arc.rs | 2 --
1 file changed, 2 deletions(-)
diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
index db9da352d588f65348aa7a5204abbb165b70197f..7e54d31538273d410f80fd65b2070e75e4f69428 100644
--- a/rust/kernel/sync/arc.rs
+++ b/rust/kernel/sync/arc.rs
@@ -127,7 +127,6 @@
/// ```
pub struct Arc<T: ?Sized> {
ptr: NonNull<ArcInner<T>>,
- _p: PhantomData<ArcInner<T>>,
}
#[pin_data]
@@ -219,7 +218,6 @@ unsafe fn from_inner(inner: NonNull<ArcInner<T>>) -> Self {
// INVARIANT: By the safety requirements, the invariants hold.
Arc {
ptr: inner,
- _p: PhantomData,
}
}
---
base-commit: ae7851c29747fa3765ecb722fe722117a346f988
change-id: 20241104-simplify-arc-70c3574b5fac
Best regards,
--
Tamir Duberstein <tamird@gmail.com>
next reply other threads:[~2024-11-04 21:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 21:23 Tamir Duberstein [this message]
2024-11-04 22:42 ` [PATCH] rust: arc: remove unused PhantomData Boqun Feng
2024-11-05 11:24 ` Tamir Duberstein
2024-11-05 12:29 ` Miguel Ojeda
2024-11-05 20:13 ` Tamir Duberstein
2024-11-06 9:26 ` Alice Ryhl
2024-11-06 13:44 ` Tamir Duberstein
2024-11-06 15:38 ` Miguel Ojeda
2024-11-06 16:41 ` Tamir Duberstein
2024-11-06 18:30 ` Miguel Ojeda
2024-11-06 19:08 ` Tamir Duberstein
2024-11-07 8:49 ` Miguel Ojeda
2024-11-06 15:38 ` Miguel Ojeda
2024-11-06 16:32 ` Tamir Duberstein
2024-11-06 18:19 ` Miguel Ojeda
2024-11-06 21:12 ` Tamir Duberstein
2024-11-07 7:55 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104-simplify-arc-v1-1-a4ffc290f905@gmail.com \
--to=tamird@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).