From: FUJITA Tomonori <fujita.tomonori@gmail.com>
To: boqun.feng@gmail.com
Cc: fujita.tomonori@gmail.com, anna-maria@linutronix.de,
frederic@kernel.org, tglx@linutronix.de, jstultz@google.com,
sboyd@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
andrew@lunn.ch, hkallweit1@gmail.com, tmgross@umich.edu,
ojeda@kernel.org, alex.gaynor@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, benno.lossin@proton.me,
a.hindborg@samsung.com, aliceryhl@google.com, arnd@arndb.de
Subject: Re: [PATCH v5 6/7] rust: Add read_poll_timeout functions
Date: Sat, 09 Nov 2024 14:15:20 +0900 (JST) [thread overview]
Message-ID: <20241109.141520.1319530714927998446.fujita.tomonori@gmail.com> (raw)
In-Reply-To: <Zyuy25viG51DDRk7@Boquns-Mac-mini.local>
On Wed, 6 Nov 2024 10:18:03 -0800
Boqun Feng <boqun.feng@gmail.com> wrote:
> On Fri, Nov 01, 2024 at 10:01:20AM +0900, FUJITA Tomonori wrote:
> [...]
>> @@ -44,6 +45,7 @@
>> pub mod page;
>> pub mod prelude;
>> pub mod print;
>> +pub mod processor;
>> pub mod sizes;
>> pub mod rbtree;
>> mod static_assert;
>> diff --git a/rust/kernel/processor.rs b/rust/kernel/processor.rs
>> new file mode 100644
>> index 000000000000..eeeff4be84fa
>> --- /dev/null
>> +++ b/rust/kernel/processor.rs
>
> What else would we put into this file? `smp_processor_id()` and IPI
> functionality?
Yeah, we would need smp_processor_id() but not sure about the other
functions. There aren't many processor-related functions that Rust
drivers directly need to call, I guess.
> If so, I would probably want to rename this to cpu.rs.
Fine by me, I'll go with cpu.rs in the next version.
I chose processor.rs just because the C side uses processor.h for
cpu_relax() but cpu.rs also looks good.
next prev parent reply other threads:[~2024-11-09 5:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 1:01 [PATCH v5 0/7] rust: Add IO polling FUJITA Tomonori
2024-11-01 1:01 ` [PATCH v5 1/7] rust: time: Add PartialEq/Eq/PartialOrd/Ord trait to Ktime FUJITA Tomonori
2024-11-01 1:01 ` [PATCH v5 2/7] rust: time: Introduce Delta type FUJITA Tomonori
2024-11-01 1:01 ` [PATCH v5 3/7] rust: time: Introduce Instant type FUJITA Tomonori
2024-11-01 1:01 ` [PATCH v5 4/7] rust: time: Add wrapper for fsleep function FUJITA Tomonori
2024-11-06 18:13 ` Boqun Feng
2024-11-09 4:38 ` FUJITA Tomonori
2024-11-01 1:01 ` [PATCH v5 5/7] MAINTAINERS: rust: Add TIMEKEEPING and TIMER abstractions FUJITA Tomonori
2024-11-01 1:01 ` [PATCH v5 6/7] rust: Add read_poll_timeout functions FUJITA Tomonori
2024-11-06 18:18 ` Boqun Feng
2024-11-09 5:15 ` FUJITA Tomonori [this message]
2024-11-06 21:35 ` Boqun Feng
2024-11-07 8:56 ` Petr Mladek
2024-11-09 9:38 ` FUJITA Tomonori
2024-11-07 12:50 ` Rasmus Villemoes
2024-11-07 12:59 ` Alice Ryhl
2024-11-07 12:59 ` Miguel Ojeda
2024-11-01 1:01 ` [PATCH v5 7/7] net: phy: qt2025: Wait until PHY becomes ready FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109.141520.1319530714927998446.fujita.tomonori@gmail.com \
--to=fujita.tomonori@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrew@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=gary@garyguo.net \
--cc=hkallweit1@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).