rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: lukas@wunner.de, Jonathan.Cameron@huawei.com,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	akpm@linux-foundation.org, bhelgaas@google.com,
	linux-pci@vger.kernel.org, linux-cxl@vger.kernel.org,
	bjorn3_gh@protonmail.com, ojeda@kernel.org, tmgross@umich.edu,
	boqun.feng@gmail.com, benno.lossin@proton.me,
	a.hindborg@kernel.org, wilfred.mallawa@wdc.com,
	alistair23@gmail.com, alex.gaynor@gmail.com, gary@garyguo.net,
	aliceryhl@google.com
Subject: Re: [RFC 1/6] rust: bindings: Support SPDM bindings
Date: Fri, 15 Nov 2024 11:53:46 -0600	[thread overview]
Message-ID: <20241115175346.GA2045933@bhelgaas> (raw)
In-Reply-To: <20241115054616.1226735-2-alistair@alistair23.me>

On Fri, Nov 15, 2024 at 03:46:11PM +1000, Alistair Francis wrote:
> In preparation for a Rust SPDM library we need to include the SPDM
> functions in the Rust bindings.
> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
>  rust/bindings/bindings_helper.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
> index 7847b2b3090b..8283e6a79ac9 100644
> --- a/rust/bindings/bindings_helper.h
> +++ b/rust/bindings/bindings_helper.h
> @@ -24,6 +24,7 @@
>  #include <linux/sched/signal.h>
>  #include <linux/sched/task.h>
>  #include <linux/slab.h>
> +#include <linux/spdm.h>

Usually an additional #include goes in the same patch that makes use
of the new .h file.  Maybe there's a different convention in rust/?

>  #include <linux/uaccess.h>
>  #include <linux/wait.h>
>  #include <linux/workqueue.h>
> -- 
> 2.47.0
> 

  reply	other threads:[~2024-11-15 17:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15  5:46 [RFC 0/6] lib: Rust implementation of SPDM Alistair Francis
2024-11-15  5:46 ` [RFC 1/6] rust: bindings: Support SPDM bindings Alistair Francis
2024-11-15 17:53   ` Bjorn Helgaas [this message]
2024-11-15 18:00     ` Miguel Ojeda
2024-11-15  5:46 ` [RFC 2/6] drivers: pci: Change CONFIG_SPDM to a dependency Alistair Francis
2024-11-15 17:58   ` Bjorn Helgaas
2024-11-22 15:30     ` Jonathan Cameron
2024-11-22 15:36       ` Miguel Ojeda
2024-11-22 17:23       ` Bjorn Helgaas
2024-11-22 18:22         ` Jonathan Cameron
2024-11-15  5:46 ` [RFC 3/6] lib: rspdm: Initial commit of Rust SPDM Alistair Francis
2024-11-15 17:15   ` Miguel Ojeda
2024-11-15 22:53   ` Dan Williams
2024-11-19  4:24     ` Alistair Francis
2024-11-22 17:31   ` Bjorn Helgaas
2024-11-23 16:14     ` Lukas Wunner
2024-11-15  5:46 ` [RFC 4/6] lib: rspdm: Support SPDM get_version Alistair Francis
2024-11-15  5:46 ` [RFC 5/6] lib: rspdm: Support SPDM get_capabilities Alistair Francis
2024-11-15  5:46 ` [RFC 6/6] lib: rspdm: Support SPDM negotiate_algorithms Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241115175346.GA2045933@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=a.hindborg@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=benno.lossin@proton.me \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=gary@garyguo.net \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=wilfred.mallawa@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).