From: Lee Jones <lee@kernel.org>
To: lee@kernel.org
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, benno.lossin@proton.me,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
rust-for-linux@vger.kernel.org
Subject: [PATCH v3 1/5] rust: miscdevice: Provide accessor to pull out miscdevice::this_device
Date: Thu, 5 Dec 2024 16:25:18 +0000 [thread overview]
Message-ID: <20241205162531.1883859-2-lee@kernel.org> (raw)
In-Reply-To: <20241205162531.1883859-1-lee@kernel.org>
There are situations where a pointer to a `struct device` will become
necessary (e.g. for calling into dev_*() functions). This accessor
allows callers to pull this out from the `struct miscdevice`.
Signed-off-by: Lee Jones <lee@kernel.org>
---
rust/kernel/miscdevice.rs | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
index 7e2a79b3ae26..55340f316006 100644
--- a/rust/kernel/miscdevice.rs
+++ b/rust/kernel/miscdevice.rs
@@ -10,11 +10,13 @@
use crate::{
bindings,
+ device::Device,
error::{to_result, Error, Result, VTABLE_DEFAULT_ERROR},
prelude::*,
str::CStr,
types::{ForeignOwnable, Opaque},
};
+
use core::{
ffi::{c_int, c_long, c_uint, c_ulong},
marker::PhantomData,
@@ -84,6 +86,13 @@ pub fn register(opts: MiscDeviceOptions) -> impl PinInit<Self, Error> {
pub fn as_raw(&self) -> *mut bindings::miscdevice {
self.inner.get()
}
+
+ /// Returns a pointer to the current Device
+ pub fn device(&self) -> &Device {
+ // SAFETY: This is only accessible after a successful register() which always
+ // initialises this_device with a valid device.
+ unsafe { Device::as_ref((*self.as_raw()).this_device) }
+ }
}
#[pinned_drop]
--
2.47.0.338.g60cca15819-goog
next prev parent reply other threads:[~2024-12-05 16:25 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 16:25 [PATCH v3 0/5] rust: miscdevice: Provide sample driver using the new MiscDevice bindings Lee Jones
2024-12-05 16:25 ` Lee Jones [this message]
2024-12-05 20:23 ` [PATCH v3 1/5] rust: miscdevice: Provide accessor to pull out miscdevice::this_device Fiona Behrens
2024-12-06 7:20 ` Lee Jones
2024-12-06 6:42 ` Greg KH
2024-12-06 7:16 ` Lee Jones
2024-12-06 7:33 ` Lee Jones
2024-12-06 7:46 ` Greg KH
2024-12-06 7:49 ` Lee Jones
2024-12-06 8:10 ` Alice Ryhl
2024-12-06 8:00 ` Boqun Feng
2024-12-06 8:07 ` Lee Jones
2024-12-06 8:15 ` Boqun Feng
2024-12-06 8:31 ` Lee Jones
2024-12-05 16:25 ` [PATCH v3 2/5] Documentation: ioctl-number: Carve out some identifiers for use by sample drivers Lee Jones
2024-12-06 6:46 ` Greg KH
2024-12-06 7:15 ` Lee Jones
2024-12-05 16:25 ` [PATCH v3 3/5] samples: rust: Provide example using the new Rust MiscDevice abstraction Lee Jones
2024-12-06 6:44 ` Greg KH
2024-12-06 7:14 ` Lee Jones
2024-12-06 7:20 ` Greg KH
2024-12-06 7:35 ` Lee Jones
2024-12-06 7:43 ` Greg KH
2024-12-06 7:51 ` Lee Jones
2024-12-06 6:49 ` Greg KH
2024-12-06 6:52 ` Arnd Bergmann
2024-12-06 7:03 ` Greg Kroah-Hartman
2024-12-06 7:36 ` Lee Jones
2024-12-06 7:12 ` Lee Jones
2024-12-06 9:01 ` Danilo Krummrich
2024-12-05 16:25 ` [PATCH v3 4/5] sample: rust_misc_device: Demonstrate additional get/set value functionality Lee Jones
2024-12-05 16:25 ` [PATCH v3 5/5] MAINTAINERS: Add Rust Misc Sample to MISC entry Lee Jones
2024-12-06 6:45 ` Greg KH
2024-12-06 7:07 ` Lee Jones
2024-12-06 7:16 ` Greg KH
2024-12-06 7:46 ` Lee Jones
2024-12-06 7:19 ` [PATCH v3 0/5] rust: miscdevice: Provide sample driver using the new MiscDevice bindings Greg KH
2024-12-06 7:44 ` Lee Jones
2024-12-06 8:11 ` Greg KH
2024-12-06 8:31 ` Alice Ryhl
2024-12-06 8:44 ` Greg KH
2024-12-06 8:51 ` Alice Ryhl
2024-12-06 8:55 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2024-12-06 9:05 [PATCH v4 0/4] " Lee Jones
2024-12-06 9:05 ` [PATCH v3 1/5] rust: miscdevice: Provide accessor to pull out miscdevice::this_device Lee Jones
2024-12-06 10:25 ` Miguel Ojeda
2024-12-06 12:05 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241205162531.1883859-2-lee@kernel.org \
--to=lee@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=arnd@arndb.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).