From: Lee Jones <lee@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, benno.lossin@proton.me,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v3 0/5] rust: miscdevice: Provide sample driver using the new MiscDevice bindings
Date: Fri, 6 Dec 2024 07:44:43 +0000 [thread overview]
Message-ID: <20241206074443.GJ8882@google.com> (raw)
In-Reply-To: <2024120632-hardwired-hardhead-1906@gregkh>
On Fri, 06 Dec 2024, Greg KH wrote:
> On Thu, Dec 05, 2024 at 04:25:17PM +0000, Lee Jones wrote:
> > It has been suggested that the driver should use dev_info() instead of
> > pr_info() however there is currently no scaffolding to successfully pull
> > a 'struct device' out from driver data post register(). This is being
> > worked on and we will convert this over in due course.
>
> But the miscdevice.rs change provides this to you, right? Or if not,
> why not?
This does allow us to pull the 'struct device *` out from `struct
miscdevice`; however, since this resides in MiscDeviceRegistration,
which we lose access to after .init, we have no means to call it.
Alice is going to work on a way to use ThisModule to get the
MiscDeviceRegistration reference back from anywhere in the module. Until
that piece lands, we can't call MiscDeviceRegistration::device() outside
of RustMiscDeviceModule.
One option that I investigated involved global mutable variable that we
could store the &Device into during MiscDeviceRegistration, however this
got messy (actually just bloaty) fast. Alice's solution will be
cleaner and more universally useful.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-12-06 7:44 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 16:25 [PATCH v3 0/5] rust: miscdevice: Provide sample driver using the new MiscDevice bindings Lee Jones
2024-12-05 16:25 ` [PATCH v3 1/5] rust: miscdevice: Provide accessor to pull out miscdevice::this_device Lee Jones
2024-12-05 20:23 ` Fiona Behrens
2024-12-06 7:20 ` Lee Jones
2024-12-06 6:42 ` Greg KH
2024-12-06 7:16 ` Lee Jones
2024-12-06 7:33 ` Lee Jones
2024-12-06 7:46 ` Greg KH
2024-12-06 7:49 ` Lee Jones
2024-12-06 8:10 ` Alice Ryhl
2024-12-06 8:00 ` Boqun Feng
2024-12-06 8:07 ` Lee Jones
2024-12-06 8:15 ` Boqun Feng
2024-12-06 8:31 ` Lee Jones
2024-12-05 16:25 ` [PATCH v3 2/5] Documentation: ioctl-number: Carve out some identifiers for use by sample drivers Lee Jones
2024-12-06 6:46 ` Greg KH
2024-12-06 7:15 ` Lee Jones
2024-12-05 16:25 ` [PATCH v3 3/5] samples: rust: Provide example using the new Rust MiscDevice abstraction Lee Jones
2024-12-06 6:44 ` Greg KH
2024-12-06 7:14 ` Lee Jones
2024-12-06 7:20 ` Greg KH
2024-12-06 7:35 ` Lee Jones
2024-12-06 7:43 ` Greg KH
2024-12-06 7:51 ` Lee Jones
2024-12-06 6:49 ` Greg KH
2024-12-06 6:52 ` Arnd Bergmann
2024-12-06 7:03 ` Greg Kroah-Hartman
2024-12-06 7:36 ` Lee Jones
2024-12-06 7:12 ` Lee Jones
2024-12-06 9:01 ` Danilo Krummrich
2024-12-05 16:25 ` [PATCH v3 4/5] sample: rust_misc_device: Demonstrate additional get/set value functionality Lee Jones
2024-12-05 16:25 ` [PATCH v3 5/5] MAINTAINERS: Add Rust Misc Sample to MISC entry Lee Jones
2024-12-06 6:45 ` Greg KH
2024-12-06 7:07 ` Lee Jones
2024-12-06 7:16 ` Greg KH
2024-12-06 7:46 ` Lee Jones
2024-12-06 7:19 ` [PATCH v3 0/5] rust: miscdevice: Provide sample driver using the new MiscDevice bindings Greg KH
2024-12-06 7:44 ` Lee Jones [this message]
2024-12-06 8:11 ` Greg KH
2024-12-06 8:31 ` Alice Ryhl
2024-12-06 8:44 ` Greg KH
2024-12-06 8:51 ` Alice Ryhl
2024-12-06 8:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206074443.GJ8882@google.com \
--to=lee@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=arnd@arndb.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).