From: Lee Jones <lee@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, benno.lossin@proton.me,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v3 1/5] rust: miscdevice: Provide accessor to pull out miscdevice::this_device
Date: Fri, 6 Dec 2024 12:05:42 +0000 [thread overview]
Message-ID: <20241206120542.GA7684@google.com> (raw)
In-Reply-To: <CANiq72=e=pNXYGN_=_R_g1UkxTPhdWc+izb0i=7_V+aAzD1c7w@mail.gmail.com>
On Fri, 06 Dec 2024, Miguel Ojeda wrote:
> On Fri, Dec 6, 2024 at 10:05 AM Lee Jones <lee@kernel.org> wrote:
> >
> > + /// Returns a pointer to the current Device
>
> Nit: please use intra-doc links wherever possible (if not possible,
> please at least format type names as code). We also end sentences with
> periods in docs and comments. So e.g.:
>
> /// Returns a pointer to the current [`Device`].
>
> There was a comment about this line in the previous version, v3, but
> there does not seem to be a change. But then again, the title of this
> patch is v3 and not v4 -- not sure what happened here.
This patch should no longer be part of the set after v3.
Looks like v3 was still in the output folder so was sent again with v4
by mistake. My tooling usually strips out old versions, so I'm not sure
what went wrong specifically.
Thanks for the comment style tips. I'll make the changes.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-12-06 12:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 9:05 [PATCH v4 0/4] rust: miscdevice: Provide sample driver using the new MiscDevice bindings Lee Jones
2024-12-06 9:05 ` [PATCH v4 1/4] Documentation: ioctl-number: Carve out some identifiers for use by sample drivers Lee Jones
2024-12-06 9:05 ` [PATCH v3 1/5] rust: miscdevice: Provide accessor to pull out miscdevice::this_device Lee Jones
2024-12-06 10:25 ` Miguel Ojeda
2024-12-06 12:05 ` Lee Jones [this message]
2024-12-06 9:05 ` [PATCH v3 2/5] Documentation: ioctl-number: Carve out some identifiers for use by sample drivers Lee Jones
2024-12-06 9:05 ` [PATCH v4 2/4] samples: rust: Provide example using the new Rust MiscDevice abstraction Lee Jones
2024-12-06 9:29 ` Danilo Krummrich
2024-12-06 9:40 ` Alice Ryhl
2024-12-06 9:58 ` Danilo Krummrich
2024-12-06 10:04 ` Arnd Bergmann
2024-12-06 10:09 ` Alice Ryhl
2024-12-06 10:29 ` Arnd Bergmann
2024-12-06 10:40 ` Alice Ryhl
2024-12-06 11:15 ` Arnd Bergmann
2024-12-06 9:05 ` [PATCH v4 3/4] sample: rust_misc_device: Demonstrate additional get/set value functionality Lee Jones
2024-12-06 9:05 ` [PATCH v3 3/5] samples: rust: Provide example using the new Rust MiscDevice abstraction Lee Jones
2024-12-06 9:05 ` [PATCH v4 4/4] MAINTAINERS: Add Rust Misc Sample to MISC entry Lee Jones
2024-12-06 9:05 ` [PATCH v3 4/5] sample: rust_misc_device: Demonstrate additional get/set value functionality Lee Jones
2024-12-06 9:05 ` [PATCH v3 5/5] MAINTAINERS: Add Rust Misc Sample to MISC entry Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2024-12-05 16:25 [PATCH v3 0/5] rust: miscdevice: Provide sample driver using the new MiscDevice bindings Lee Jones
2024-12-05 16:25 ` [PATCH v3 1/5] rust: miscdevice: Provide accessor to pull out miscdevice::this_device Lee Jones
2024-12-05 20:23 ` Fiona Behrens
2024-12-06 7:20 ` Lee Jones
2024-12-06 6:42 ` Greg KH
2024-12-06 7:16 ` Lee Jones
2024-12-06 7:33 ` Lee Jones
2024-12-06 7:46 ` Greg KH
2024-12-06 7:49 ` Lee Jones
2024-12-06 8:10 ` Alice Ryhl
2024-12-06 8:00 ` Boqun Feng
2024-12-06 8:07 ` Lee Jones
2024-12-06 8:15 ` Boqun Feng
2024-12-06 8:31 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206120542.GA7684@google.com \
--to=lee@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=arnd@arndb.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).