From: guilherme giacomo simoes <trintaeoitogc@gmail.com>
To: miguel.ojeda.sandonis@gmail.com
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com,
aliceryhl@google.com, benno.lossin@proton.me,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com,
fujita.tomonori@gmail.com, gary@garyguo.net,
linux-kernel@vger.kernel.org, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, tahbertschinger@gmail.com,
tmgross@umich.edu, trintaeoitogc@gmail.com,
walmeida@microsoft.com, wcampbell1995@gmail.com
Subject: Re: [PATCH] rust: macros: add authors
Date: Fri, 6 Dec 2024 22:47:10 -0300 [thread overview]
Message-ID: <20241207014710.447144-1-trintaeoitogc@gmail.com> (raw)
In-Reply-To: <CANiq72neo_RtANWJu_GW5LxsR5KWxriS1L8nsXkNn7ioiaEQKQ@mail.gmail.com>
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrotes:
> I understand what you mean, but changing a few existing lines here and
> there is fine. There aren't that many modules out there. If we are
> going to change this, then the best time is now. Backporting should
> not be too bad either.
Yeah, in the truth, don't have file a lot for changes.
> Sorry, I am not sure I understand what you mean. Yes, the idea of this
> option is to repeat one line per author, but that is not a big deal: C
> modules do that already.
I understand that in the C side is already this way, but maybe we have a better
way for make this.
I'm think about this, and for me, the less the developer need a think about
"what field I need use in this problem" is better. This is not because is really
difficult think about "I need use author or authors", but if we can avoid, I
think that is better.
Well .. that said, after your tips, I change my mind and how we don't have file
a lot for change the type authors, maybe the better way is a unique field
called "authors" and this should ever be array.
If my module have a unique author, so `authors: ["author"]`, if the module have
two or more authors, so `authors: ["author_1", "author_2", "author_n"]`. With
this way, the module developers just have a one way to declare the author of
module. Don't have different fields, don't have different types. Have a only
one way for declare the authors of module.
Thoughts?
You think that we need open a chat in zulipchat for this, and collect more
opinions?
next prev parent reply other threads:[~2024-12-07 1:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 19:22 [PATCH] [PATCH] rust: macros: add authors guilherme giacomo simoes
2024-12-06 20:17 ` Miguel Ojeda
2024-12-06 21:19 ` guilherme giacomo simoes
2024-12-06 22:42 ` Miguel Ojeda
2024-12-07 1:47 ` guilherme giacomo simoes [this message]
2024-12-07 10:14 ` [PATCH] " Daniel Sedlak
2024-12-07 16:07 ` guilherme giacomo simoes
2024-12-09 12:21 ` Daniel Sedlak
2024-12-09 11:47 ` [PATCH] " Miguel Ojeda
2024-12-09 12:29 ` Daniel Sedlak
2024-12-09 13:14 ` guilherme giacomo simoes
2024-12-09 12:55 ` guilherme giacomo simoes
2024-12-09 3:59 ` [PATCH] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241207014710.447144-1-trintaeoitogc@gmail.com \
--to=trintaeoitogc@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tahbertschinger@gmail.com \
--cc=tmgross@umich.edu \
--cc=walmeida@microsoft.com \
--cc=wcampbell1995@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).