Re: [PATCH v13 0/2] rust: xarray: Add a minimal abstraction for XArray

Tamir Duberstein
2024-12-13T23:22:58Z

On Fri, Dec 13, 2024 at 4:31 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Fri, Dec 13, 2024 at 9:02 PM Tamir Duberstein <tamird@gmail.com> wrote:
> >
> > Changes in v13:
> > - Replace `bool::then` with `if`. (Miguel Ojeda)
> > - Replace `match` with `let` + `if`. (Miguel Ojeda)
>
> Personally, I would also use the early return style in both of these,
> like in C.

My personal preference is to leave it as-is as the return keyword
isn't used anywhere in this file at the moment. I don't mind you
changing it if/when applying, though.

> I think you may also omit the parenthesis in the first one.

Oops, you're right.