From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A142414AD2D; Tue, 7 Jan 2025 12:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736251246; cv=none; b=JNmfxr6TxTDlc6+z8iJhtsySj6bol3p1GnEvAnN/aP0kz+X8+N0SIdee1rQrmI9LNtkJVI9srBKeXjLGeKuwOs7ZZhX07jZa8+FL0Ve6I2KyQnfJhRt/8aSVsSJ3DT4YFWMiK7ofwY9pmpLj9sUPxAL2CTEEv+qOikCbOwX/CNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736251246; c=relaxed/simple; bh=ZR1lSFv84QRbwim/wKRWVL7gUxFQbxrvPHagzNf6QaM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cep8GB1V4ui3xZHvvdhz1TfsBZVakCKdVaoRWNTpi89nbPSAtrzpC4jeEptm4o7WHfy/Rx/jBikCn4lUdGHH4B+kuvq7XUDuvh/b65GR5KRCn/icr+z4mCagrvJYqy2P4g4nynmpr2WPDbtzXXkaoEfZfc065z+OYE7Y/ilaYNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nRN8iLh/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nRN8iLh/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6892C4CED6; Tue, 7 Jan 2025 12:00:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1736251246; bh=ZR1lSFv84QRbwim/wKRWVL7gUxFQbxrvPHagzNf6QaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nRN8iLh/rs2FsJy0gnvYqA0097zG572nuZ5+HRelaPIWaEy7xBotwxvAp4R786HaG p2g+QGK7dHNQDQZJ9UysgKEfkYVFKvgtUr9/Cek6yB2VSQb0K9mC4Dlf9j0o6JXgyo wQpkZVnWHjWKMTlmTkpB1EUeL2C8qO4OyPxso6s4= Date: Tue, 7 Jan 2025 13:00:43 +0100 From: Greg KH To: Viresh Kumar Cc: "Rafael J. Wysocki" , Miguel Ojeda , Danilo Krummrich , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , linux-pm@vger.kernel.org, Vincent Guittot , Stephen Boyd , Nishanth Menon , rust-for-linux@vger.kernel.org, Manos Pitsidianakis , Erik Schilling , Alex =?iso-8859-1?Q?Benn=E9e?= , Joakim Bech , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [PATCH V6 03/15] cpufreq: Rust implementation doesn't parse BIT() macro Message-ID: <2025010752-vagrantly-juiciness-cd81@gregkh> References: <9719ba8b3a921bd9f2cb7ebf902c54c708b5409d.1736248242.git.viresh.kumar@linaro.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9719ba8b3a921bd9f2cb7ebf902c54c708b5409d.1736248242.git.viresh.kumar@linaro.org> On Tue, Jan 07, 2025 at 04:51:36PM +0530, Viresh Kumar wrote: > Rust isn't able to parse the macro for now, avoid using it. No, please fix it. You don't want to have to fend off the checkpatch.pl cleanups that this would cause of people putting the BIT() macro back. Make BIT() work properly for Rust code as well, it has to be done eventually, right? thanks, greg k-h