From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D047415E97 for ; Thu, 9 Jan 2025 05:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736399693; cv=none; b=P6ID4QFoXBpS6orifNv7fAYrtxKc+VRnP7CqcbiEtTf3SaiU+5shXZTG1GM3lbV9dQsC39WOeUYLWjm2xnzASQ+o1RJcSO7dKHWCmMiDFhdYFW4lH3Uz6GXH2o7F8ekORUQVXdFgGpNNz3umP58BuVUJeDe+hbjZWeifRkXn6wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736399693; c=relaxed/simple; bh=kCmPpkSLiAKVuZ95e/7mKBE+sinlh6/yM1qdu2FaZR8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TDZV19dvMC7AK8plWFXPkeD9V+f0c2XuOwxzP5BtVUX3nBESPzxpYou1icik4Ow38KSdxpUSF9IuU0oYc2Sjys4Emlmj2EwLnDKeav4S/guXO8VmLCffhh3VxZyJtFElcQrgevdbX5HV7XHUOjjyV4GNnh5AexlQhDMCAaZTpG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LHwOicnQ; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LHwOicnQ" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2ee51f8c47dso732569a91.1 for ; Wed, 08 Jan 2025 21:14:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736399691; x=1737004491; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zpvr7W3/jJn0AS0gG1/EuGnzadSe4E7oYDGzSsbTQWw=; b=LHwOicnQABRdOBII9j/Vj4yWwrXEqXjXuAyygajBWJJEs8ShdgnIHmGTiyAu1OeH/G gWNIqfpuw88Cx3JKMi1T+zi8y/bRD5grKN7FsE2u5lltHkZPaolkpUDvTVQznnU/W6/g RhOTJlTz2mqMqkuthG6rhcsbncNYiyqrmw4dhAIjdGuVwU/57nf6VUvz+09K06vqxjZT SmpDO+fDNwdr8KsoJqqCDD3j4wZBMmBzmlvQiLN+2bWoENU9HWwL4yOm/Iu3b+LIi6n9 tUsRU6msvo3E5tSq+BstLqoMHXVoYpBWQn+HzSI7Jk09m8OrmywxjbczOz+hsH4uvVCS d8ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736399691; x=1737004491; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zpvr7W3/jJn0AS0gG1/EuGnzadSe4E7oYDGzSsbTQWw=; b=VimVhB2/weoSK+pfZgBlElXRbqiAX7RPCOOZVAa5eNBVLuYbTRXu9Y2EdySkUVogQq 5qKPe4jdJmTBlkiURxE33zVxB5BnpXRLVzCehecmtZO4fmiOTn72TrK0L2ZRfu3Cluo+ xmo8W0MjLdY5zWalUVxKWEbFlm3xHNFEYVnCK0aLVNndcCIHlIyjo3AvKA8xGMPn/ZHP psAHHQ4anlN8ts1ACczjNekgZZ5JDBlOZwcG9wrlJ3siqEtS3BnKB/SrajiJN3bp81Yq 7B0pnvIFHwuSPt4gq3aCDzl+U7oo3Q41pMFEX6b+KWu2cm49ZWK1/8RNzNc2Sop2x2Wk YO7A== X-Forwarded-Encrypted: i=1; AJvYcCUD6pOMhGr3F3wGg9xVpfd5Nrey/4M4ndgoFqpM9wuPjsHI94iRyv4pDzcgnAbjh+NLCvjWzJJKkrnDEdPzmQ==@vger.kernel.org X-Gm-Message-State: AOJu0YxQQEyDoFBO/N0/6u1C69+w26+u+eIOGOSaWWOodF12dZIT65a+ KJ962/a05CrhL0gh+fPlmHwNajsKGiDk5VrPD1Rsu2ScQY1LH3/SH03xDt0kuWM= X-Gm-Gg: ASbGnctEBdSOesKPKk2u94126MRaUeTBl4R0nNUHfiPIu07OAiDqRkSK+KwTIcwjfKz l32hMQE2UmwPPSGCou3iuvtsxqGNNMLwsoJxNjERSZgaq1l1ilp6CdGM2rqXRGld2wjVKRZDumJ 56GJJrhUYjcWfJ6GH4zkdT4NHKxiE5sFCr6BMoNEvO/7oreOyyH/LqDXNQDnS1JTESl+soXo2jq wADMBe9XZ0YI9XuxluuZtFU6+juoJTcUJUGnTVuNdJK+ovLihBiSWy64LI= X-Google-Smtp-Source: AGHT+IEoV9m5MeEWcpU/+NuG/OXICA2uZ6J/IzU4JO9kw3gQrINA8J+Ec6p2KiJvjnTmUXVCV2Xo2w== X-Received: by 2002:a05:6a00:2c86:b0:71e:e4f:3e58 with SMTP id d2e1a72fcca58-72d21fbcf06mr8331717b3a.17.1736399691119; Wed, 08 Jan 2025 21:14:51 -0800 (PST) Received: from localhost ([122.172.84.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8164d3sm36167387b3a.15.2025.01.08.21.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 21:14:50 -0800 (PST) Date: Thu, 9 Jan 2025 10:44:48 +0530 From: Viresh Kumar To: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" , Miguel Ojeda , Danilo Krummrich , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , linux-pm@vger.kernel.org, Vincent Guittot , Stephen Boyd , Nishanth Menon , rust-for-linux@vger.kernel.org, Manos Pitsidianakis , Erik Schilling , Alex =?utf-8?Q?Benn=C3=A9e?= , Joakim Bech , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [PATCH V6 04/15] rust: device: Add few helpers Message-ID: <20250109051448.xfjbzle7becrnows@vireshk-i7> References: <429b7539f787ad360cd28fd1db6dc3d6c1fe289d.1736248242.git.viresh.kumar@linaro.org> <2025010734-march-cultivate-bd96@gregkh> <20250108110242.dwhdlwnyjloz6dwb@vireshk-i7> <2025010835-uncover-pamphlet-de5b@gregkh> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2025010835-uncover-pamphlet-de5b@gregkh> On 08-01-25, 12:52, Greg Kroah-Hartman wrote: > How about fixing the reference count of the cpu device? :) I would try my best to avoid getting into that trap :) > But seriously, this is NOT a generic 'struct device' thing, it is a 'cpu > device' thing. So putting this function in device.rs is probably not > the proper place for it at all, sorry. Why not put it in the cpu.rs > file instead? I can do that, so it will be a standalone helper function in cpu.rs and not a method in an `impl` block. -- viresh