From: Andreas Hindborg <a.hindborg@kernel.org>
To: Miguel Ojeda <ojeda@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Danilo Krummrich <dakr@kernel.org>
Cc: "Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Lyude Paul" <lyude@redhat.com>,
"Guangbo Cui" <2407018371@qq.com>,
"Dirk Behme" <dirk.behme@gmail.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Andreas Hindborg" <a.hindborg@kernel.org>
Subject: [PATCH v6 04/14] rust: hrtimer: implement `HrTimerPointer` for `Arc`
Date: Fri, 10 Jan 2025 21:15:27 +0100 [thread overview]
Message-ID: <20250110-hrtimer-v3-v6-12-rc2-v6-4-f71d50f16482@kernel.org> (raw)
In-Reply-To: <20250110-hrtimer-v3-v6-12-rc2-v6-0-f71d50f16482@kernel.org>
This patch allows the use of intrusive `hrtimer` fields in structs that are
managed by an `Arc`.
Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
---
rust/kernel/time/hrtimer.rs | 3 +-
rust/kernel/time/hrtimer/arc.rs | 89 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 91 insertions(+), 1 deletion(-)
diff --git a/rust/kernel/time/hrtimer.rs b/rust/kernel/time/hrtimer.rs
index 31c461ddd2c377101ed6c1c7e009f7dccf458ebc..d0842c7c4c6ddffeef9a79cbf9727819060e4333 100644
--- a/rust/kernel/time/hrtimer.rs
+++ b/rust/kernel/time/hrtimer.rs
@@ -98,7 +98,6 @@ unsafe fn raw_get(ptr: *const Self) -> *mut bindings::hrtimer {
/// # Safety
///
/// `self_ptr` must point to a valid `Self`.
- #[allow(dead_code)]
pub(crate) unsafe fn raw_cancel(self_ptr: *const Self) -> bool {
// SAFETY: timer_ptr points to an allocation of at least `HrTimer` size.
let c_timer_ptr = unsafe { HrTimer::raw_get(self_ptr) };
@@ -294,3 +293,5 @@ unsafe fn raw_get_timer(ptr: *const Self) ->
}
}
}
+
+mod arc;
diff --git a/rust/kernel/time/hrtimer/arc.rs b/rust/kernel/time/hrtimer/arc.rs
new file mode 100644
index 0000000000000000000000000000000000000000..4c1812f190bc7a9e0b2fcd5ea2e320f45ba584bc
--- /dev/null
+++ b/rust/kernel/time/hrtimer/arc.rs
@@ -0,0 +1,89 @@
+// SPDX-License-Identifier: GPL-2.0
+
+use super::HasHrTimer;
+use super::HrTimer;
+use super::HrTimerCallback;
+use super::HrTimerHandle;
+use super::HrTimerPointer;
+use super::RawHrTimerCallback;
+use crate::sync::Arc;
+use crate::sync::ArcBorrow;
+use crate::time::Ktime;
+
+/// A handle for an `Arc<HasHrTimer<U>>` returned by a call to
+/// [`HrTimerPointer::start`].
+pub struct ArcHrTimerHandle<U>
+where
+ U: HasHrTimer<U>,
+{
+ pub(crate) inner: Arc<U>,
+}
+
+// SAFETY: We implement drop below, and we cancel the timer in the drop
+// implementation.
+unsafe impl<U> HrTimerHandle for ArcHrTimerHandle<U>
+where
+ U: HasHrTimer<U>,
+{
+ fn cancel(&mut self) -> bool {
+ let self_ptr = Arc::as_ptr(&self.inner);
+
+ // SAFETY: As we obtained `self_ptr` from a valid reference above, it
+ // must point to a valid `U`.
+ let timer_ptr = unsafe { <U as HasHrTimer<U>>::raw_get_timer(self_ptr) };
+
+ // SAFETY: As `timer_ptr` points into `U` and `U` is valid, `timer_ptr`
+ // must point to a valid `HrTimer` instance.
+ unsafe { HrTimer::<U>::raw_cancel(timer_ptr) }
+ }
+}
+
+impl<U> Drop for ArcHrTimerHandle<U>
+where
+ U: HasHrTimer<U>,
+{
+ fn drop(&mut self) {
+ self.cancel();
+ }
+}
+
+impl<U> HrTimerPointer for Arc<U>
+where
+ U: Send + Sync,
+ U: HasHrTimer<U>,
+ U: for<'a> HrTimerCallback<CallbackTarget<'a> = Self>,
+{
+ type TimerHandle = ArcHrTimerHandle<U>;
+
+ fn start(self, expires: Ktime) -> ArcHrTimerHandle<U> {
+ // SAFETY: Since we generate the pointer passed to `start` from a
+ // valid reference, it is a valid pointer.
+ unsafe { U::start(Arc::as_ptr(&self), expires) };
+
+ ArcHrTimerHandle { inner: self }
+ }
+}
+
+impl<U> RawHrTimerCallback for Arc<U>
+where
+ U: HasHrTimer<U>,
+ U: for<'a> HrTimerCallback<CallbackTarget<'a> = Self>,
+ U: for<'a> HrTimerCallback<CallbackTargetParameter<'a> = ArcBorrow<'a, U>>,
+{
+ unsafe extern "C" fn run(ptr: *mut bindings::hrtimer) -> bindings::hrtimer_restart {
+ // `HrTimer` is `repr(C)`
+ let timer_ptr = ptr.cast::<super::HrTimer<U>>();
+
+ // SAFETY: By C API contract `ptr` is the pointer we passed when
+ // queuing the timer, so it is a `HrTimer<T>` embedded in a `T`.
+ let data_ptr = unsafe { U::timer_container_of(timer_ptr) };
+
+ // SAFETY: `data_ptr` points to the `U` that was used to queue the
+ // timer. This `U` is contained in an `Arc`.
+ let receiver = unsafe { ArcBorrow::from_raw(data_ptr) };
+
+ U::run(receiver);
+
+ bindings::hrtimer_restart_HRTIMER_NORESTART
+ }
+}
--
2.47.0
next prev parent reply other threads:[~2025-01-10 20:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 20:15 [PATCH v6 00/14] hrtimer Rust API Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 01/14] rust: time: Add Ktime::from_ns() Andreas Hindborg
2025-01-14 17:04 ` Tamir Duberstein
2025-01-16 14:11 ` Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 02/14] rust: hrtimer: introduce hrtimer support Andreas Hindborg
2025-01-14 17:23 ` Tamir Duberstein
2025-01-16 19:06 ` Andreas Hindborg
2025-01-16 19:13 ` Miguel Ojeda
2025-01-21 13:33 ` Alice Ryhl
2025-02-03 11:41 ` Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 03/14] rust: sync: add `Arc::as_ptr` Andreas Hindborg
2025-01-14 17:24 ` Tamir Duberstein
2025-01-16 19:20 ` Andreas Hindborg
2025-02-03 22:46 ` Tamir Duberstein
2025-02-03 23:44 ` Boqun Feng
2025-02-04 9:56 ` Andreas Hindborg
2025-01-17 9:10 ` Alice Ryhl
2025-01-10 20:15 ` Andreas Hindborg [this message]
2025-01-10 20:15 ` [PATCH v6 05/14] rust: hrtimer: allow timer restart from timer handler Andreas Hindborg
2025-01-14 17:32 ` Tamir Duberstein
2025-01-15 11:21 ` Andreas Hindborg
2025-01-16 0:21 ` Tamir Duberstein
2025-01-16 13:26 ` Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 06/14] rust: hrtimer: add `UnsafeHrTimerPointer` Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 07/14] rust: hrtimer: add `hrtimer::ScopedHrTimerPointer` Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 08/14] rust: hrtimer: implement `UnsafeHrTimerPointer` for `Pin<&T>` Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 09/14] rust: hrtimer: implement `UnsafeHrTimerPointer` for `Pin<&mut T>` Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 10/14] rust: alloc: add `Box::into_pin` Andreas Hindborg
2025-01-13 16:12 ` Danilo Krummrich
2025-01-10 20:15 ` [PATCH v6 11/14] rust: hrtimer: implement `HrTimerPointer` for `Pin<Box<T>>` Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 12/14] rust: hrtimer: add `HrTimerMode` Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 13/14] rust: hrtimer: add clocksource selection through `ClockSource` Andreas Hindborg
2025-01-10 20:15 ` [PATCH v6 14/14] rust: hrtimer: add maintainer entry Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110-hrtimer-v3-v6-12-rc2-v6-4-f71d50f16482@kernel.org \
--to=a.hindborg@kernel.org \
--cc=2407018371@qq.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dirk.behme@gmail.com \
--cc=frederic@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).