From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9AF24C79; Fri, 31 Jan 2025 07:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738309678; cv=none; b=WOMqRoOU7wc4d2leUlqzTUz3KP82IFlDOcoZmSit1pdEbHW4ar2H1zQp4Uaso9wgxwTNVXPgmHuoB/aVHqw4kQboSQTnlWulD9qWjc1hZdfvk8cNpu4JNBfIHTmm7ShIp4QX28D4gyTSmFPcvf61vXYNjJnZFGYDKsA/n3oTugk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738309678; c=relaxed/simple; bh=9KrbAGChLqoeNT3MQUvj/T9v6fbmxb1jzCiBIdxSa+Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HCo8Nrh3gSdpX09/nC0cpHcfM6+Oo9ynkL65+Zueba5EqQDnHNL0TvFy6sS0UhoSr38biI4mtsSyylyFKK9f02Q9yFeYSicjPqCeCy56DwTSXNGNC9SiU/mR0T3vh9VFa9sjfMKS+ynhoB4qtCShyzN4qsuLJ2Fan5r2ne+qaiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Xe6rsbif; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Xe6rsbif" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27CE4C4CED1; Fri, 31 Jan 2025 07:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1738309677; bh=9KrbAGChLqoeNT3MQUvj/T9v6fbmxb1jzCiBIdxSa+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xe6rsbif5zlZ7WayknOJZEC6cg/g+dNcOgdbWtMLRuvTemGFrZWRzVIWM0/T4PkU+ W8kc1nu8fN9NUcrD8sJrWycqUSkMXoW5RZhAaqpWoPySLgXpOnB23uqQcgnFIIWxBK IArxyDxHfdfH1bx7gv3WSPOlkDtWt+d5JXFE56ns= Date: Fri, 31 Jan 2025 08:47:54 +0100 From: Greg KH To: Jason Gunthorpe Cc: phasta@kernel.org, Christoph Hellwig , Danilo Krummrich , Miguel Ojeda , Abdiel Janulgue , daniel.almeida@collabora.com, aliceryhl@google.com, robin.murphy@arm.com, rust-for-linux@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Valentin Obst , open list , Marek Szyprowski , airlied@redhat.com, "open list:DMA MAPPING HELPERS" Subject: Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction. Message-ID: <2025013148-reversal-pessimism-1515@gregkh> References: <20250109080812.GA20431@lst.de> <20250110083955.GA5395@lst.de> <20250128092334.GA28548@lst.de> <293df3d54bad446e8fd527f204c6dc301354e340.camel@mailbox.org> <20250130154646.GA2298732@nvidia.com> <2025013030-gummy-cosmic-7927@gregkh> <20250130172437.GN5556@nvidia.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250130172437.GN5556@nvidia.com> On Thu, Jan 30, 2025 at 01:24:37PM -0400, Jason Gunthorpe wrote: > On Thu, Jan 30, 2025 at 05:11:43PM +0100, Greg KH wrote: > > On Thu, Jan 30, 2025 at 11:46:46AM -0400, Jason Gunthorpe wrote: > > > On Thu, Jan 30, 2025 at 02:19:16PM +0100, Philipp Stanner wrote: > > > > would some sort of official statement by the "entire community" > > > > reassure you that the burden of keeping Rust abstractions working with > > > > any changes on the C side rests entirely on the Rust side's > > > > shoulders? > > > > > > You'd have to reconcile that with the recent event where Linus defered > > > the MM pull request and some C patches were dropped because of rust > > > kbuild bugs: > > > > > > https://lore.kernel.org/linux-mm/CAHk-=whddBhfi5DUi370W3pYs+z3r2E7KYuHjwR=a1eRig5Gxg@mail.gmail.com/ > > > > > > It seems to me the message is now crystal clear, and the opposite of > > > what you claim. > > > > > > All PRs to Linus must not break the rust build and the responsibilty > > > for that falls to all the maintainers. If the Rust team is not quick > > > enough to resolve any issues during the development window then > > > patches must be dropped before sending PRs, or Linus will refuse the > > > PR. > > > > > > Effectively this seems to imply that patches changing some of the C > > > API cannot be merged by maintainers unless accompanied by matching > > > Rust hunks. > > > > > > If there are different instructions to maintainers I would be > > > interested to know. > > > > That's not the case, the one you point at above was a tooling issue that > > people missed due to the holidays. Fixing it up was simple enough and > > people did so and moved on. > > Regardless of holidays, you seem to be saying that Linus should have > accepted Andrew's PR and left rust with build failures? I can't answer for Linus, sorry. But a generic "hey, this broke our working toolchain builds" is something that is much much much different than "an api changed so I now have to turn off this driver in my build" issue. thanks, greg k-h