From: Greg KH <greg@kroah.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: airlied@gmail.com, simona@ffwll.ch, corbet@lwn.net,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, ajanulgu@redhat.com, lyude@redhat.com,
pstanner@redhat.com, zhiw@nvidia.com, cjia@nvidia.com,
jhubbard@nvidia.com, bskeggs@nvidia.com, acurrid@nvidia.com,
ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@kernel.org,
aliceryhl@google.com, tmgross@umich.edu,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 1/2] gpu: nova-core: add initial driver stub
Date: Sat, 1 Feb 2025 09:33:28 +0100 [thread overview]
Message-ID: <2025020151-leverage-unadorned-fb05@gregkh> (raw)
In-Reply-To: <20250131220432.17717-1-dakr@kernel.org>
On Fri, Jan 31, 2025 at 11:04:24PM +0100, Danilo Krummrich wrote:
> +impl Gpu {
> + pub(crate) fn new(pdev: &pci::Device, bar: Devres<Bar0>) -> Result<impl PinInit<Self>> {
> + let spec = GpuSpec::new(&bar)?;
> + let fw = Firmware::new(pdev.as_ref(), &spec, "535.113.01")?;
> +
> + dev_info!(
> + pdev.as_ref(),
> + "NVIDIA {:?} ({:#x})",
> + spec.chipset,
> + spec.boot0
> + );
When drivers work properly, they should be quiet, so can you move this
to dev_dbg()?
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-01 8:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 22:04 [PATCH 1/2] gpu: nova-core: add initial driver stub Danilo Krummrich
2025-01-31 22:04 ` [PATCH 2/2] gpu: nova-core: add initial documentation Danilo Krummrich
2025-02-04 18:40 ` Timur Tabi
2025-02-04 18:56 ` Danilo Krummrich
2025-02-01 4:01 ` [PATCH 1/2] gpu: nova-core: add initial driver stub John Hubbard
2025-02-01 13:52 ` Danilo Krummrich
2025-02-01 19:43 ` John Hubbard
2025-02-01 8:14 ` Karol Herbst
2025-02-01 8:16 ` Karol Herbst
2025-02-01 12:08 ` Danilo Krummrich
2025-02-01 8:33 ` Greg KH [this message]
2025-02-01 12:12 ` Danilo Krummrich
2025-02-01 15:31 ` Greg KH
2025-02-03 20:24 ` Joel Fernandes
2025-02-03 20:59 ` John Hubbard
2025-02-03 21:53 ` Joel Fernandes
2025-02-04 18:46 ` Danilo Krummrich
2025-02-04 21:09 ` Joel Fernandes
2025-02-04 18:42 ` Timur Tabi
2025-02-04 18:56 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025020151-leverage-unadorned-fb05@gregkh \
--to=greg@kroah.com \
--cc=a.hindborg@kernel.org \
--cc=acurrid@nvidia.com \
--cc=airlied@gmail.com \
--cc=ajanulgu@redhat.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bskeggs@nvidia.com \
--cc=cjia@nvidia.com \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=pstanner@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).